Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make string construciton more clear #19536

Merged
merged 1 commit into from Jul 4, 2017

Conversation

davidlange6
Copy link
Contributor

The lack of a + between strings seems to confuse clang-tidy.

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21124/console Started: 2017/07/04 11:29

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

L1TriggerConfig/GMTConfigProducers

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

Comparison job queued.

@davidlange6
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit 2b42465 into cms-sw:master Jul 4, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19536/21124/summary.html

Comparison Summary:

  • You potentially added 15 lines to the logs
  • Reco comparison results: 1773 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1756015
  • DQMHistoTests: Total failures: 31457
  • DQMHistoTests: Total nulls: 35
  • DQMHistoTests: Total successes: 1724357
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants