Allow TrackClusterRemover to work on either pixel or strip clusters alone #19543
Conversation
|
A new Pull Request was created by @JanFSchulte (Jan-Frederik Schulte) for master. It involves the following packages: RecoLocalTracker/SubCollectionProducers @perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@cmsbuild please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
Hi @slava77, thanks for looking at this. Thanks, |
|
+1
|
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
| @@ -51,8 +51,8 @@ namespace { | |||
| const TrackCollectionTokens trajectories_; | |||
| edm::EDGetTokenT<QualityMaskCollection> srcQuals; | |||
|
|
|||
| const edm::EDGetTokenT<edmNew::DetSetVector<SiPixelCluster> > pixelClusters_; | |||
| const edm::EDGetTokenT<edmNew::DetSetVector<SiStripCluster> > stripClusters_; | |||
| edm::EDGetTokenT<edmNew::DetSetVector<SiPixelCluster> > pixelClusters_; | |||
There was a problem hiding this comment.
hi @JanFSchulte - why does this const need to be removed?
There was a problem hiding this comment.
If those stay const, compilation fails with this error:
data/user/jschulte/CMSSW_9_2_4/src/RecoLocalTracker/SubCollectionProducers/src/TrackClusterRemover.cc:98:19: error: passing 'const edm::EDGetTokenT<edmNew::DetSetVector >' as 'this' argument discards qualifiers [-fpermissive]
pixelClusters_ = consumes<edmNew::DetSetVector >(pixelClusters);
There was a problem hiding this comment.
they can no longer be const because they are assigned to in the constructor, instead of being initialised in the initialisation list
|
+1 |
Right now, the TrackClusterRemover uses both pixel and strip clusters at all times. This PR introduces the possibility to have it run on either of them alone.