Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back port feature allowing special value @currentProcess for InputTag process name #19600

Merged
merged 3 commits into from Jul 9, 2017

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Jul 6, 2017

This back port of PR #19491 was requested by @fwyzard.

(I also included in this the bug fix for skipCurrentProcess because the test code for the 2 PRs was intertwined. That bug fix should only affect code run in SubProcesses so it shouldn't do any harm because it is usually not executed. If it did actually get run, then the bug fix is probably needed).

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_9_2_X.

It involves the following packages:

FWCore/Framework
FWCore/Integration
FWCore/ParameterSet
FWCore/Utilities

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @felicepantaleo, @ebrondol, @makortel this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@wddgit
Copy link
Contributor Author

wddgit commented Jul 6, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21233/console Started: 2017/07/06 22:37

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@fwyzard
Copy link
Contributor

fwyzard commented Jul 6, 2017

Thank you !

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

-1

Tested at: 60cc308

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
8443a0b
52bd9cb
9d371db
4026a45
c406fab
126ddef
7b17e42
c8aff7c
f8de05e
01de002
fc51b5b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19600/21233/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19600/21233/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19600/21233/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
8443a0b
52bd9cb
9d371db
4026a45
c406fab
126ddef
7b17e42
c8aff7c
f8de05e
01de002
fc51b5b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19600/21233/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19600/21233/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19600/21233/summary.html

Comparison Summary:

  • You potentially added 28 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1812182
  • DQMHistoTests: Total failures: 14925
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1797091
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@Dr15Jones
Copy link
Contributor

@smuzaffar did the unit test build time out again?

@smuzaffar
Copy link
Contributor

@Dr15Jones , yes looks like timed out after 15520 secs

@Dr15Jones
Copy link
Contributor

@davidlange6 please ignore the test failure. The version in 9_3 works fine.

@davidlange6 davidlange6 merged commit 1b62efc into cms-sw:CMSSW_9_2_X Jul 9, 2017
@wddgit wddgit deleted the backportCurrentProcess branch November 29, 2017 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants