Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[92X] update conditions for unit test #19615

Merged
merged 1 commit into from Jul 19, 2017

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 7, 2017

backport of #19507

This resolves the same issue as in master branch:

After kmcdermo@96d3942ed305266ec45f92e02ea58f04bffc5e36the list of files picked up by the unit test via:

from PhysicsTools.PatAlgos.patInputFiles_cff import filesRelValTTbarPileUpGENSIMRECO

points to a phase-I MC sample, hence breaking the unit test: example of log file.
This commit restores the previous behavior.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_9_2_X.

It involves the following packages:

Alignment/OfflineValidation

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21253/console Started: 2017/07/07 15:43

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19615/21253/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1816199
  • DQMHistoTests: Total failures: 29445
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1786588
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@mmusich
Copy link
Contributor Author

mmusich commented Jul 10, 2017

Hi @arunhep @franzoni, can this PR be signed?
The changes are trivial and will just allow to have a clean record in terms of unit tests.
Incidentally any PR attempting to backport changes to the Alignment/OfflineValidation subsystem will systematically fail PR tests because the reference IB is failing as well.
Thanks

@arunhep
Copy link
Contributor

arunhep commented Jul 10, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c271641 into cms-sw:CMSSW_9_2_X Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants