Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to ECAL pedestal PCL: break histos in several folders. Add monitoring plots : 92X backport of #19439 #19621

Merged
merged 1 commit into from Jul 19, 2017

Conversation

argiro
Copy link
Contributor

@argiro argiro commented Jul 7, 2017

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2017

A new Pull Request was created by @argiro for CMSSW_9_2_X.

It involves the following packages:

Calibration/EcalCalibAlgos

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@franzoni
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21308/console Started: 2017/07/10 16:42

@boudoul
Copy link
Contributor

boudoul commented Jul 10, 2017

Hi @argiro , may I kindly ask you to update the title (and the description) of this PR, when looking at the release notes which will eventually contain this PR , it will be hard to understand quickly what is the purpose of this backport - Thank you

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19621/21308/summary.html

Comparison Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1816301
  • DQMHistoTests: Total failures: 14936
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1801199
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@argiro argiro changed the title 92X backport of #19439 Improvements to ECAL pedestal PCL: break histos in several folders. Add monitoring plots : 92X backport of #19439 Jul 11, 2017
@franzoni
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 029f436 into cms-sw:CMSSW_9_2_X Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants