Detector Description Clang Check modernize-loop-convert

[ianna]

DetectorDescription part of @davidlange6's PR #19649

Note, I added a second commit to correct the loops with a promise of not modifying the values:
from

for( auto it : vec )

to

for( const auto & it :vec )

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21402/console Started: 2017/07/12 16:42

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/Core
DetectorDescription/Parser
DetectorDescription/RegressionTest

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 2995e11
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19705/21402/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
de56eaa
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19705/21402/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19705/21402/git-merge-result

[cmsbuild]

Comparison job queued.

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19705/21402/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 2015567
• DQMHistoTests: Total failures: 106
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2015295
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 93 log files, 14 edm output root files, 23 DQM output files