New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove errant Eras.py imports #19732
Conversation
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages: DQM/HcalTasks @perrotta, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @slava77, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1
@smuzaffar @kpedro88 is there a way to implement a code rule that would prevent direct |
On 7/17/17 11:42 AM, Kevin Pedro wrote:
@slava77 <https://github.com/slava77> I don't know of a way in Python to
prevent imports, but there's some ongoing discussion in #14895
<#14895> about permanent ways to
avoid this problem in the future
we have QA scripts that parse parts of the code.
While the import can not be prevented at execution level,
it can still be noted by jenkins in the code rules or in a similar QA check.
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19732 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbmociSZA3cbQ_vkQcxUKy6YA7OIqks5sO6r4gaJpZM4OXchk>.
|
merge |
Modifiers should be implemented from their own cff files, not from
Configuration.StandardSequences.Eras
(to reduce unnecessary dependencies). See #14895.