Dijet Prompt DQM for JEC #19873

bobaekim · 2017-07-24T04:23:34Z

///Trigger Paths///
HLT_DiPFJetAve40
HLT_DiPFJetAve60
HLT_DiPFJetAve80
HLT_DiPFJetAve140
HLT_DiPFJetAve200
HLT_DiPFJetAve260
HLT_DiPFJetAve320
HLT_DiPFJetAve400
HLT_DiPFJetAve500
HLT_DiPFJetAve60_HFJEC
HLT_DiPFJetAve80_HFJEC
HLT_DiPFJetAve100_HFJEC
HLT_DiPFJetAve160_HFJEC
HLT_DiPFJetAve220_HFJEC
HLT_DiPFJetAve300_HFJEC

///Histograms///
pt_1 : pt of leading jet passed trigger and w/o offline selection
pt_2 : pt of second leading jet passed trigger and w/o offline selection
pt_avg_b : using (pt_1 + pt_2) * 0.5 , pt average before offline selection
pt_tag : tag jet passed trigger and offline selection satisfied with fabs(eta) < 1.3
pt_prb : probe jet passed trigger and offline selection, satisfied with fabs(eta) > 1.3 among pt_1 and pt_2
(If both pt_1 and pt_2 are satisfied with fabs(eta) < 1.3, tag and probe are randomly selected.)
pt_asym : using (pt_prb - pt_tag)/(pt_tag + pt_prb), asymmetry of pt_tag and pt_prb
pt_avg_a : using (pt_tab + pt_prb) * 0.5 , pt average after offline selection
eta_prb : eta of probe jet
pt_Asym_VS_eta_prb : 2D historgram of pt_asym and eta_prb

Anastasia asked.

cmsbuild · 2017-07-24T04:23:55Z

A new Pull Request was created by @bobaekim (Bobae Kim) for master.

It involves the following packages:

DQMOffline/Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

mtosi · 2017-07-24T10:52:57Z

couldn't you make use of the generic
https://github.com/bobaekim/cmssw/blob/c8d388ec1aae417dbea4b921ce001afdd0685995/DQMOffline/Trigger/plugins/TriggerDQMBase.cc
?

mtosi · 2017-07-24T10:53:36Z

DQMOffline/Trigger/plugins/DiJetMonitor.cc

+      return;
+  }
+  for ( reco::PFJetCollection::const_iterator ibegin = offjets->begin(), iend = offjets->end(), ijet = ibegin; ijet != iend; ++ijet ) {
+    if (ijet->pt()< 20) {continue;}


why don't you make use of a jetSelector ?

mtosi · 2017-07-24T10:54:52Z

DQMOffline/Trigger/plugins/DiJetMonitor.cc

+//---- Additional DiJet offline selection------
+bool DiJetMonitor::dijet_selection(double eta_1, double phi_1, double eta_2, double phi_2, double pt_1, double pt_2, int &tag_id, int &probe_id){
+  bool passeta; //check that one of the jets in the barrel
+  if (abs(eta_1)< 1.3 || abs(eta_2) < 1.3 ) 


please, do not use hard coded / magic numbers

mtosi · 2017-07-24T10:55:08Z

DQMOffline/Trigger/plugins/DiJetMonitor.cc

+
+  float delta_phi_1_2= (phi_1 - phi_2);
+  bool other_cuts;//check that jets are back to back
+  if (abs(delta_phi_1_2) >= 2.7)


no magic number w/in the code, please

mtosi · 2017-07-24T10:55:53Z

DQMOffline/Trigger/python/DiJetMonitor_cff.py

+# DiPFjetAve320
+DiPFjetAve320_Prommonitoring = DiPFjetAve40_Prommonitoring.clone()
+DiPFjetAve320_Prommonitoring.FolderName = cms.string('HLT/JetMET/HLT_DiPFJetAve320/')
+DiPFjetAve320_Prommonitoring.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_DiPFJetAve320_v*")


I think you need to make use of the variable binning for the pt distribution

mtosi · 2017-07-24T10:56:16Z

shouldn't you need the eta-phi plot as well ?

bobaekim · 2017-07-25T07:34:00Z

Dear mia, Thank you for your comments. - I'm modifying code using generic code. - About dijet offline selection, when Anastasia asked me to make a code, she gave me this selection code. So I used it. I don't understand 'magic number in code' about dijet offline selection. If you don't mind, could you let me know ? - About the eta-phi plot, when Anastasia asked me to make histograms, eta-phi plot isn't included. So I didn't make eta-phi plot. Thank you. Bobae 2017-07-24 12:56 GMT+02:00 mia tosi <notifications@github.com>:

…

shouldn't you need the eta-phi plot as well ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19873 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARJbYwSziP06azjlHI6WhP9bBonNkg9Zks5sRHhRgaJpZM4Ogtf1> .

mtosi · 2017-07-25T08:04:29Z

ciao

On Tue, Jul 25, 2017 at 9:34 AM, Bobae Kim ***@***.***> wrote: Dear mia, Thank you for your comments. - I'm modifying code using generic code. thanks - About dijet offline selection, when Anastasia asked me to make a code, she gave me this selection code. So I used it. I don't understand 'magic number in code' about dijet offline selection. If you don't mind, could you let me know ?

I think it is not good practice having hard-coded numbers in the code

- About the eta-phi plot, when Anastasia asked me to make histograms, eta-phi plot isn't included. So I didn't make eta-phi plot.

it is a request of TSG coordinators and STEAM group ;)

…

Thank you. Bobae 2017-07-24 12:56 GMT+02:00 mia tosi ***@***.***>: > shouldn't you need the eta-phi plot as well ? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#19873 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/ ARJbYwSziP06azjlHI6WhP9bBonNkg9Zks5sRHhRgaJpZM4Ogtf1> > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19873 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEt58xnaMgW5rhYBdx05UJEZrkXZZCauks5sRZppgaJpZM4Ogtf1> .

fwyzard · 2017-07-25T08:57:21Z

tracked by #19142

bobaekim · 2017-07-25T09:45:20Z

Dear mia, Thank you for your reply fast and letting me know those. As your comment, I'll also add eta-phi plot. Thank you a lot. Bobae 2017-07-25 10:25 GMT+02:00 mia tosi <notifications@github.com>:

…

ciao On Tue, Jul 25, 2017 at 9:34 AM, Bobae Kim ***@***.***> wrote: > Dear mia, > > Thank you for your comments. > > - I'm modifying code using generic code. > > thanks > - About dijet offline selection, when Anastasia asked me to make a code, > she gave me this selection code. > So I used it. > I don't understand 'magic number in code' about dijet offline selection. > If you don't mind, could you let me know ? > I think it is not good practice having hard-coded numbers in the code > > - About the eta-phi plot, when Anastasia asked me to make histograms, > eta-phi plot isn't included. > So I didn't make eta-phi plot. > it is a request of TSG coordinators and STEAM group ;) > > Thank you. > Bobae > > > 2017-07-24 12:56 GMT+02:00 mia tosi ***@***.***>: > > > shouldn't you need the eta-phi plot as well ? > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub > > <#19873 (comment)>, or > mute > > the thread > > <https://github.com/notifications/unsubscribe-auth/ > ARJbYwSziP06azjlHI6WhP9bBonNkg9Zks5sRHhRgaJpZM4Ogtf1> > > . > > > > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#19873 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/ AEt58xnaMgW5rhYBdx05UJEZrkXZZCauks5sRZppgaJpZM4Ogtf1> > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19873 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARJbYyV44_1q6Gc_24ksHQ6kPzXuUzFYks5sRaGQgaJpZM4Ogtf1> .

fwyzard · 2017-08-03T15:31:38Z

It's been over a week, please post the update to the code ASAP.

bobaekim · 2017-08-07T08:55:30Z

Dear Bocci, Sorry for late replying. I'm testing this code. I'll update soon. Thank you. 2017-08-04 0:31 GMT+09:00 Andrea Bocci <notifications@github.com>:

…

It's been over a week, please post the update to the code ASAP. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19873 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARJbY27HVeujRoN3hKAR0_EQLbuZsPBwks5sUefdgaJpZM4Ogtf1> .

dmitrijus · 2018-02-13T13:57:44Z

-1

I think we can afford a 1mb of memory. But not the printouts...

and there is storm of printouts added by this PR it would seem...

fabiocos · 2018-02-19T12:45:03Z

@bobaekim is this PR still needed?

bobaekim · 2018-02-20T06:28:28Z

Dear all,
I'm sorry for late replying.
Could you want me to modify bins of 2D histograms and update this PR?
Thank you in advance.

fabiocos · 2018-02-26T08:51:06Z

please test

cmsbuild · 2018-02-26T08:51:25Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26301/console Started: 2018/02/26 09:52

cmsbuild · 2018-02-26T10:26:39Z

+1
Tested at: 4a22f12
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19873/26301/summary.html

cmsbuild · 2018-02-26T10:26:42Z

Comparison job queued.

cmsbuild · 2018-02-26T11:17:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19873/26301/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-19873/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017

Comparison Summary:

You potentially added 853 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 29
DQMHistoTests: Total histograms compared: 2500248
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2500071
DQMHistoTests: Total skipped: 176
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 20851.22 KiB( 23 files compared)
Checked 118 log files, 9 edm output root files, 29 DQM output files

bobaekim · 2018-02-26T16:13:44Z

Dear all,
I'm sorry for bothering you.
I'm modifying and testing code in 10_0_X version.
In order to reduce memory, numerator and denominator histograms which are not involved in efficiency plot will be removed.
And to adjust bin of 2D histogram, I'm looking at JetMonitor code as reference.
I'll make PR within 1 or 2 days.
Sorry in advance.

Best regards,
Bobae

fabiocos · 2018-02-26T16:19:46Z

@bobaekim thanks, please also check the output messages, according to the test lots of lines are added to the log files...

bobaekim · 2018-03-03T09:04:35Z

Dear all,

I'll update PR here.
#22443
Thank you in advance.

Best regards,
Bobae

fabiocos · 2018-03-03T10:10:56Z

@bobaekim so if this PR is now obsolete and superseded by #22443, please close it

Update dijet prompt dqm (#19873)

bobaekim added 9 commits July 20, 2017 17:50

update for running dijetdqm code

a94e3d4

update for monitoring dijet plots

cb07b1c

update for monitoring dijet plots

fea501c

update for monitoring dijet plots

e264d10

update for monitoring dijet plots

b66ba78

update for dijet monitoring cc file

eea2767

update dijet monitoring h file

5ff2d9e

update dijet monitoring config file

52778a5

update dijet monitoring cff file

c8d388e

cmsbuild added this to the CMSSW_9_3_X milestone Jul 24, 2017

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Jul 24, 2017

mtosi reviewed Jul 24, 2017

View reviewed changes

bobaekim added 2 commits August 8, 2017 06:37

update for dijet prompt monitoring

574363a

update for dijet prompt monitoring

2f82a07

cmsbuild added dqm-rejected pending-signatures and removed dqm-approved fully-signed labels Feb 13, 2018

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Feb 26, 2018

cmsbuild added tests-started and removed tests-pending labels Feb 26, 2018

cmsbuild added tests-approved and removed tests-started labels Feb 26, 2018

cmsbuild added comparison-available and removed comparison-pending labels Feb 26, 2018

This was referenced Mar 3, 2018

Update dijet promptdqm (#19873) #22442

Closed

Update dijet prompt dqm (#19873) #22443

Merged

bobaekim closed this Mar 3, 2018

cmsbuild added a commit that referenced this pull request Mar 7, 2018

Merge pull request #22443 from bobaekim/update-dijetpromptdqm

1106ee8

Update dijet prompt dqm (#19873)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dijet Prompt DQM for JEC #19873

Dijet Prompt DQM for JEC #19873

bobaekim commented Jul 24, 2017

cmsbuild commented Jul 24, 2017

mtosi commented Jul 24, 2017

mtosi Jul 24, 2017

mtosi Jul 24, 2017

mtosi Jul 24, 2017

mtosi Jul 24, 2017

mtosi commented Jul 24, 2017

bobaekim commented Jul 25, 2017 via email

mtosi commented Jul 25, 2017 via email

fwyzard commented Jul 25, 2017

bobaekim commented Jul 25, 2017 via email

fwyzard commented Aug 3, 2017

bobaekim commented Aug 7, 2017 via email

dmitrijus commented Feb 13, 2018 •

edited

fabiocos commented Feb 19, 2018

bobaekim commented Feb 20, 2018

fabiocos commented Feb 26, 2018

cmsbuild commented Feb 26, 2018 •

edited

cmsbuild commented Feb 26, 2018

cmsbuild commented Feb 26, 2018

cmsbuild commented Feb 26, 2018

bobaekim commented Feb 26, 2018

fabiocos commented Feb 26, 2018

bobaekim commented Mar 3, 2018

fabiocos commented Mar 3, 2018

Dijet Prompt DQM for JEC #19873

Dijet Prompt DQM for JEC #19873

Conversation

bobaekim commented Jul 24, 2017

cmsbuild commented Jul 24, 2017

mtosi commented Jul 24, 2017

mtosi Jul 24, 2017

Choose a reason for hiding this comment

mtosi Jul 24, 2017

Choose a reason for hiding this comment

mtosi Jul 24, 2017

Choose a reason for hiding this comment

mtosi Jul 24, 2017

Choose a reason for hiding this comment

mtosi commented Jul 24, 2017

bobaekim commented Jul 25, 2017 via email

mtosi commented Jul 25, 2017 via email

fwyzard commented Jul 25, 2017

bobaekim commented Jul 25, 2017 via email

fwyzard commented Aug 3, 2017

bobaekim commented Aug 7, 2017 via email

dmitrijus commented Feb 13, 2018 • edited

fabiocos commented Feb 19, 2018

bobaekim commented Feb 20, 2018

fabiocos commented Feb 26, 2018

cmsbuild commented Feb 26, 2018 • edited

cmsbuild commented Feb 26, 2018

cmsbuild commented Feb 26, 2018

cmsbuild commented Feb 26, 2018

bobaekim commented Feb 26, 2018

fabiocos commented Feb 26, 2018

bobaekim commented Mar 3, 2018

fabiocos commented Mar 3, 2018

dmitrijus commented Feb 13, 2018 •

edited

cmsbuild commented Feb 26, 2018 •

edited