Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rearranging some plots saving bins #20005

Merged
merged 1 commit into from Aug 2, 2017
Merged

rearranging some plots saving bins #20005

merged 1 commit into from Aug 2, 2017

Conversation

fioriNTU
Copy link
Contributor

@fioriNTU fioriNTU commented Aug 1, 2017

This PR rearrange some plots in the Phase 1 DQM, basically what is done is to switch the roles of residuals and cluster probability plots with cluster charge and size plots (much more important to monitor the detector). Since the first pair of plots have a number of bins or 150 and 50 respectively, while the cluster charge and size have 100 and 30 respectively, we have gain in number of bins.

Additionally few plots produced in the TrackEfficiency plugin are completely removed

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

A new Pull Request was created by @fioriNTU for master.

It involves the following packages:

DQM/SiPixelPhase1Common
DQM/SiPixelPhase1RecHits
DQM/SiPixelPhase1TrackClusters
DQM/SiPixelPhase1TrackEfficiency
DQM/SiPixelPhase1TrackResiduals

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @hdelanno this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22002/console Started: 2017/08/02 10:51

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20005/22002/summary.html

There are some workflows for which there are errors in the baseline:
1306.0 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2585121
  • DQMHistoTests: Total failures: 46539
  • DQMHistoTests: Total nulls: 211
  • DQMHistoTests: Total successes: 2538190
  • DQMHistoTests: Total skipped: 181
  • DQMHistoTests: Total Missing objects: 0
  • Checked 102 log files, 14 edm output root files, 25 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6e42d43 into cms-sw:master Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants