Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make L1TMuon offline DQM histogram binning configurable from config file #20032

Conversation

thomreis
Copy link
Contributor

@thomreis thomreis commented Aug 3, 2017

Make L1TMuon offline DQM histogram binning configurable from config file.

@thomreis
Copy link
Contributor Author

thomreis commented Aug 3, 2017

backport of #20025

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2017

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_9_2_X.

It involves the following packages:

DQMOffline/L1Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn can you please review it and eventually sign? Thanks.
@kreczko, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor

rekovic commented Aug 4, 2017

please test

@rekovic
Copy link
Contributor

rekovic commented Aug 4, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22086/console Started: 2017/08/04 11:31

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20032/22086/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1791774
  • DQMHistoTests: Total failures: 14565
  • DQMHistoTests: Total nulls: 24
  • DQMHistoTests: Total successes: 1777019
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Aug 8, 2017

@dmitrijus please sign

93x PR has been merged 6 days ago.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1d79e98 into cms-sw:CMSSW_9_2_X Aug 10, 2017
@thomreis thomreis deleted the l1tmuon_offline_dqm_variable_binning_fix_exception_92x branch August 30, 2017 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants