Updated muon mc classifier #20051
Updated muon mc classifier #20051
Conversation
|
A new Pull Request was created by @abbiendi for master. It involves the following packages: MuonAnalysis/MuonAssociators @cmsbuild, @civanch, @mdhildreth, @monttj can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
| edm::LogVerbatim("MuonMCClassifier") <<"\t TP pdgId = "<<hitsPdgId[i] << ", vertex rho = " << prodRho[i] << ", z = " << prodZ[i]; | ||
|
|
||
| // added info on GEANT process producing the TrackingParticle | ||
| std::vector<SimVertex> G4Vs = tp->parentVertex()->g4Vertices(); |
There was a problem hiding this comment.
hi @abbiendi - this can be const std::vector &G4Vs to avoid an unneeded copy
|
The code-checks are being triggered in jenkins. |
|
Pull request #20051 was updated. @cmsbuild, @civanch, @mdhildreth, @monttj can you please check and sign again. |
|
+code-checks |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
merge |
This is an update of the MC truth association tools for muons.
The association of reco::Muons has been updated to allow the association of (Global || Tracker) muons. The MuonMCClassifier has been updated and few bugs have been fixed.
The tools can be used to assess the performance of Muon ID and have been employed for the Particle-Flow performance paper (PRF-14-001).
The new code was initially developed in that context (in 7_4_X) and extensively tested there.
Now it has been ported to CMSSW_9_3_X and tested on MC events with "RelVal"-like content.
An example is provided, running on Phase2 events having the TrackingParticles in the event content:
MuonAnalysis/MuonAssociators/test/MuonMCClassifier/testClassByHitsTP_cfg.py
This PR is relevant for performance studies (e.g. Phase2 Muon TDR) and in general for developments in the muon ID validation.
@calabria