Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements for multithreading #201

Merged
merged 3 commits into from Aug 5, 2013

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jul 30, 2013

No description provided.

@wmtan
Copy link
Contributor Author

wmtan commented Jul 30, 2013

This pull request is a collection of several changes to prepare for the multithreaded framework.
Here are the changes:

  1. Functions ParameterSetEntry::pset(), VParameterSetEntry::vpSet(), ThreadSafeRegistry::data(), and ThreadSafeRegistry::extra() came in both const and non-const versions, making it difficult to tell when the underlying data was modified. The non-const versions of these functions were renamed by appending a "ForUpdate" to each function name. This is the only change that affected the DQM, HLT, and Visualization packages, each of which called one or more of these functions.
  2. The value_ptr template in FWCore/Utilities was improved by adding a constructor and an assignment operator from a std::unique_ptr.
  3. A new template, atomic_value_ptr, was added to FWCore/Utilities. This is similar to a value_ptr, but the underlying pointer used is a std::atomic<T*>, rather than a T*, which allows atomic operations. A unit test was added for the new template.
  4. An underscore was appended to the name of each data member of VParameterSetEntry, making the naming consistent with ParameterSetEntry and other framework classes.
  5. The data members ParameterSetEntry::theID_, VParameterSetEntry::theIDs_, and ParameterSet::id_ were made non-mutable.
  6. The data members ParameterSetEntry::thePSet_ and VParameterSetEntry:theVPSet_ were changed from a value_ptr to an atomic_value_ptr so they could be updated in a thread safe manner.
  7. Some functions related to parameter sets had their signatures modified to take arguments by reference or const reference rather than by pointer, where this change was appropriate.
  8. BranchKey was changed from a struct to a class to avoid public data members.
  9. Mutables in History and *Aux were made non-mutable.
  10. Some C++11 improvements in affected code, namely range for loops and the use of nullptr.

@nclopezo
Copy link
Contributor

nclopezo commented Aug 1, 2013

Hi

I took CMSSW_7_0_X_2013-07-30-1400, pulled these changes, ran the unit tests and the RelVals. All tests passed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2013

The following categories have been signed by chrjones (a.k.a. @Dr15Jones on GitHub): Core, Visualization

@cms-git-visualization, @cms-git-core, @cms-git-geometry

@ktf
Copy link
Contributor

ktf commented Aug 2, 2013

@rovere @deguio @Martin-Grunewald can you please check this is fine with you and sign?

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2013

The following categories have been signed by @deguio: DQM

@cms-git-dqm

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2013

The following categories have been signed by gruenew (a.k.a. @Martin-Grunewald on GitHub): HLT

@cms-git-hlt, @cms-git-fastsim

3 similar comments
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2013

The following categories have been signed by gruenew (a.k.a. @Martin-Grunewald on GitHub): HLT

@cms-git-hlt, @cms-git-fastsim

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2013

The following categories have been signed by gruenew (a.k.a. @Martin-Grunewald on GitHub): HLT

@cms-git-hlt, @cms-git-fastsim

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2013

The following categories have been signed by gruenew (a.k.a. @Martin-Grunewald on GitHub): HLT

@cms-git-hlt, @cms-git-fastsim

ktf added a commit that referenced this pull request Aug 5, 2013
@ktf ktf merged commit befbf80 into cms-sw:CMSSW_7_0_X Aug 5, 2013
@wmtan wmtan deleted the variousImprovementsForMultithreading branch August 5, 2013 21:04
jshlee referenced this pull request in gem-sw/cmssw May 27, 2014
nclopezo pushed a commit to nclopezo/cmssw that referenced this pull request Nov 21, 2014
parbol pushed a commit to parbol/cmssw that referenced this pull request Mar 5, 2015
NAF submission and local MC component
gechen pushed a commit to gechen/cmssw that referenced this pull request Apr 28, 2016
cmsbuild pushed a commit that referenced this pull request Jul 11, 2018
fwyzard added a commit to fwyzard/cmssw that referenced this pull request Nov 28, 2018
Remove obsolete files under EventFilter/SiPixelRawToDigi/test/ .
bi-ran pushed a commit to bi-ran/cmssw that referenced this pull request May 10, 2019
* add function to calculate PF isolation variables that are subtracted for UE
* fix calculation bug
ttrk added a commit to ttrk/cmssw that referenced this pull request Jun 24, 2019
* add function to calculate PF isolation variables that are subtracted for UE
* fix calculation bug
ttrk added a commit to ttrk/cmssw that referenced this pull request Jun 24, 2019
* add function to calculate PF isolation variables that are subtracted for UE
* fix calculation bug
slava77 pushed a commit to slava77/cmssw that referenced this pull request Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants