add warnings to L1TGlobalPrescaler (92x) #20145
Conversation
- warn if `l1tPrescales` has the wrong number of elements - warn if the target prescales are lower than the original ones
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_9_2_X. It involves the following packages: L1Trigger/L1TGlobal @cmsbuild, @rekovic, @mulhearn can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
backport #20144 |
|
type bugfix |
Enabled checks:
boost-use-to-string
cppcoreguidelines-no-malloc
google-build-explicit-make-pair
misc-inefficient-algorithm
misc-string-compare
misc-uniqueptr-reset-release
modernize-avoid-bind
modernize-deprecated-headers
modernize-loop-convert
modernize-make-shared
modernize-make-unique
modernize-pass-by-value
modernize-redundant-void-arg
modernize-replace-auto-ptr
modernize-shrink-to-fit
modernize-use-auto
modernize-use-bool-literals
modernize-use-emplace
modernize-use-equals-default
modernize-use-equals-delete
modernize-use-nullptr
modernize-use-override
modernize-use-transparent-functors
modernize-use-using
performance-faster-string-find
performance-for-range-copy
performance-implicit-cast-in-loop
performance-inefficient-string-concatenation
performance-type-promotion-in-math-fn
performance-unnecessary-copy-initialization
performance-unnecessary-value-param
readability-container-size-empty
readability-redundant-string-cstr
readability-static-definition-in-anonymous-namespace
readability-uniqueptr-delete-release
See http://releases.llvm.org/4.0.0/tools/clang/tools/extra/docs/clang-tidy/index.html for details.
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
cmsbuild
added
comparison-available
backport-ok
and removed
comparison-pending
backport
labels
|
+1 |
l1tPrescaleshas the wrong number of elements