Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to GEM-CSC integrated local trigger for Phase2 #20191

Merged
merged 29 commits into from Aug 29, 2017
Merged

Updates to GEM-CSC integrated local trigger for Phase2 #20191

merged 29 commits into from Aug 29, 2017

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Aug 16, 2017 •
edited

This pull request is an intermediate step towards fully updating the GEM-CSC local triggers for Phase2. It fixes the most pressing issues in the ME11 and ME21 motherboards, namely the construction of the ALCT-GEM type LCTs. The code is far from cleaned up yet. I plan to do that in a final pull request in this series.

Updated version of #19778

@tahuang1991

Sven Dildick and others added 25 commits July 17, 2017 19:01
update local trigger
3b151e1 
Conflicts:
	L1Trigger/CSCTriggerPrimitives/src/CSCMotherboard.cc
	L1Trigger/CSCTriggerPrimitives/src/CSCMotherboardME21GEM.cc
bugfixes
8383801
fix luts
554e7ef
add debug comments
1b0636e
use correct paramset
780f1c8
optimize matching
86c614c
manually improve the LUTs
a214404
manually fix LUTs
53c4ffe
update LUTs
1dbe656
optimize matching algos
4f95d99
do not build CLCT-GEM
a420030
clean quality definition
9261e93
@tahuang1991
merged from Sven's updates
b86b491
@tahuang1991
fixed ILT algorithm
4a7f09d
delete obsolete file
ab5045a
update config
2b33b8d
remove ring
c9b4edb
remove redundant parameter
e631140
suggestions by David Lange
77f5dff
better version of sorting algo
c7008b1
cleanup
9ab17e1
delete obsolete LUT
06cf957
fix LUT construction
0381bcc
delete test directory
0f5697a
solve merge conflicts
cd718b8
@cmsbuild cmsbuild added this to the CMSSW_9_3_X milestone Aug 16, 2017
@cmsbuild
Copy link
Contributor

Pull request #20191 was updated. @cmsbuild, @rekovic, @mulhearn can you please check and sign again.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20191/328

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20191/329

@davidlange6
Copy link
Contributor

please test

1 similar comment
@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22505/console Started: 2017/08/25 22:44

@cmsbuild
Copy link
Contributor

+1
Tested at: ef4b6f2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20191/22505/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
759801e
c61529f
25345c1
99c0a96
c0d3aa3
715f2aa
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20191/22505/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20191/22505/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20191/22505/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2653934
  • DQMHistoTests: Total failures: 245
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2653500
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@dildick
Copy link
Contributor Author

dildick commented Aug 26, 2017

@rekovic can you sign again, please?

@rekovic
Copy link
Contributor

rekovic commented Aug 29, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d7afa91 into cms-sw:master Aug 29, 2017
@dildick dildick deleted the from-CMSSW_9_3_X_2017-08-16-1100-GEM-CSC-TMB-ILT-updates branch September 6, 2017 20:19
@dildick dildick mentioned this pull request Sep 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlange6 davidlange6 davidlange6 left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed l1-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_3_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dildick @cmsbuild @davidlange6 @rekovic @smuzaffar @tahuang1991