Run2-sim18 Clean up the test area of SimG4CMS/Calo

[bsunanda]

Correct CaloSimHitStudy and clean up the test programs for HF(PMT), HO and Hit patterns in calorimeter

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

SimG4CMS/Calo

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22363/console Started: 2017/08/17 16:47

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20196/181

[cmsbuild]

+1
Tested at: d70a1e2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20196/22363/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
5506301
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20196/22363/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20196/22363/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20196/22363/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2653169
• DQMHistoTests: Total failures: 281
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2652699
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1