Correcting path names

[mohsinwaseem]

Path names ending in v* did not seem to work and thus code was returning empty histograms. It is strange as the same naming convention seem to work fine in other scripts.

This PR is to update the path names ending from _v* to _v

[cmsbuild]

A new Pull Request was created by @mohsinwaseem for master.

It involves the following packages:

DQMOffline/Trigger
HLTriggerOffline/Top

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20213/213

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20213/213/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20213/213/git-diff.patch | patch -p1

In future, you can run scram build code-checks to apply code checks

[mtosi]

did you test your update ?
do you get filled histos ? running on which samples ?
looking at one of the most recent HLT menu [1], for instance
I see that
HLT_Mu20 is highly PS'd .. are you really interested in it ?
then, I doubt the TOP PAG is interested in path HLT_TkMu20 ... it is not available !!!

the electron paths seem to have analogous issue
where do you find HLT_Ele30_eta2p1_WPTight_Gsf ?

while, for double leptons,
are you sure TOP PAG is interested in path HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL ?
it seems to be highly PS'd !
and again the comment on the TkMu flavour .......

please, point me to your DQM file w/ filled histograms
then, we will start the integration test

thanks

[1]
https://cmsweb.cern.ch/confdb/#config=/cdaq/physics/Run2017/2e34/v2.2.1/HLT/V1

[mohsinwaseem]

Yes I tested the update using ttbar sample for 200 events. The file is located at [1].

I will update the paths after finishing consultation with the TOP PAG. If you say, I can close this PR and open new when I am done?

[1]/afs/cern.ch/user/m/mather/public/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO.root

[mtosi]

just update this, please we will start the integration test when your update will be available thanks !

…

On 21 Aug 2017, at 19:03, mohsinwaseem ***@***.***> wrote: Yes I tested the update using ttbar sample for 200 events. The file is located at [1]. I will update the paths after finishing consultation with the TOP PAG. If you say, I can close this PR and open new when I am done? [1]/afs/cern.ch/user/m/mather/public/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO.root — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

Pull request #20213 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20213/316

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

Pull request #20213 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

Pull request #20213 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20213/413

[mtosi]

@mohsinwaseem are you sure about the last 3 commits ?

[mtosi]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22613/console Started: 2017/08/31 15:03

[mohsinwaseem]

@mtosi
I did not intend to do these commits. What I trying was to commit changed to 92X .. (backporting) but it somehow went into this PR.

Is it possible to disregard todays commits?

[mtosi]

thanks to @fwyzard
git push -f my-cmssw 4d2122781ed63b746c1041d4ba094e7c5e640c78:from-CMSSW_9_3_0_pre3

ps:
next time, please
do
git checkout -b <NAME OF YOUR BRANCH>

[mtosi]

ah, I forgot, the 4d2122781ed63b746c1041d4ba094e7c5e640c78 comes from the last commit you made and you want to keep

[cmsbuild]

+1
Tested at: 513546d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20213/22613/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
513546d
50050e9
94fab3e
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20213/22613/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20213/22613/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20213/22613/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2650806
• DQMHistoTests: Total failures: 479
• DQMHistoTests: Total nulls: 25
• DQMHistoTests: Total successes: 2650113
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1