Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More dE/dx info in AOD #20236

Merged
merged 10 commits into from Sep 1, 2017
Merged

More dE/dx info in AOD #20236

merged 10 commits into from Sep 1, 2017

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Aug 22, 2017

Save prescaled dE/dx hit information for low pt tracks, to allow calibration on AOD
It also declares the producer for Ih as in EXO-16-036 but I didn't add it to the event content yet.

Presentation: https://indico.cern.ch/event/660773/
I checked also the rates of tracks from the JetHT PD in the recent run 300575, where before prescaling I see ~10 tracks/event in region A (pt > 10), 85 tracks/event in region B (low pt, high dE/dx) and ~550 tracks/event in region C (low pt, low dEdx)

I can also push in this PR the changes from code-checks and the static analyzer for the RecoTracker/DeDx package, but I didn't want to mix that with the content-related changes.
Those changes are in this diff

@arizzi @jozzez1

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for master.

It involves the following packages:

RecoTracker/DeDx

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20236/250

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20236/250/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20236/250/git-diff.patch | patch -p1

In future, you can run scram build code-checks to apply code checks

@VinInn
Copy link
Contributor

VinInn commented Aug 22, 2017

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 22, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22429/console Started: 2017/08/22 18:34

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 31, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22620/console Started: 2017/08/31 16:15

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20236/22620/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2656041
  • DQMHistoTests: Total failures: 252
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 2655598
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Sep 1, 2017

code-checks

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20236/442

@perrotta
Copy link
Contributor

perrotta commented Sep 1, 2017

+1

  • Additional dedx info added on a prescaled number of low pt tracks
  • The pseudorandom generator used to prescale only depends on the seed made by evt/lumiblock, and it is therefore by itself thread-safe. (It will not be any more thread-safe if there are other non reproducibilities somewhere else which modify the number of tracks, but this is not a matter for this PR)
  • The additonal eventsize, measured on a TTbar sample with PU (wf 10224), is in line with the expectations reported in the attached slides:
    0.0 -> 32.7 33 NEWO 0.00 intedmValueMap_dedxHitInfo_prescale_RECO.
    96539.7 -> 96551.0 11 0.0 0.00 recoTracks_generalTracks__RECO.
    2477.9 -> 3086.4 609 21.9 0.03 recoDeDxHitInfos_dedxHitInfo__RECO.

2373002 -> 2373660 658 0.0 ALL BRANCHES

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d576b48 into cms-sw:master Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants