Tune Pixel Cluster Shape Filter to mitigate BPIX1 inefficiency #20269

VinInn · 2017-08-25T06:37:47Z

This PR introduced ~~three~~ two changes:

uses a 99.9% instead of 99.5% Filter for BPIX1 L1
For all other layers uses a Filter trained w/o L1
~~3) For Quadruplets apply filter to hits 2,3,4 instead of 1,2,3~~

For performances please look to next posts

cmsbuild · 2017-08-25T06:38:08Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-08-25T06:38:08Z

A new Pull Request was created by @VinInn (Vincenzo Innocente) for master.

It involves the following packages:

HLTrigger/Configuration
RecoPixelVertexing/PixelLowPtUtilities
RecoPixelVertexing/PixelTriplets

@perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @geoff-smith, @Martin-Grunewald, @jalimena, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

VinInn · 2017-08-25T06:39:30Z

MTV ttbar pu35 1000 events:
http://innocent.home.cern.ch/innocent/RelVal/DQM_V0001_R000000001__RelValTTBAR35__CMSSW_9_3_X__CSFtrim2/plots_summary/summary_ntracks.pdf

please note: as shown in next posts MonteCarlo does not reproduce data.
so the 5% increase in fakes is absolutely irrelevant at the moment....

cmsbuild · 2017-08-25T06:42:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20269/309

VinInn · 2017-08-25T06:46:04Z

Comparison Data MC:
to access the DQM please

tunnel to Marco's server

ssh -L8060:mrovere-dqmgui-slc6.cern.ch:8060 lxplus.cern.ch

open

http://127.0.0.1:8060/dqm/dev/start?runnr=300631;dataset=/SingleMuon/CMSSW_9_3_X/csftrim;sampletype=offline_data;filter=all;referencepos=overlay;referenceshow=all;referencenorm=True;referenceobj1=other%3A%3A/SingleMuon/CMSSW_9_3_X/ori%3A;referenceobj2=other%3A1%3A/RelValTTBAR35/CMSSW_9_3_X/ori%3A;referenceobj3=other%3A1%3A/RelValTTBAR35/CMSSW_9_3_X/CSFtrim1%3A;referenceobj4=other%3A1%3A/RelValTTBAR35/CMSSW_9_3_X/CSFtrim2%3A;search=;striptype=object;stripruns=;stripaxis=run;stripomit=none;workspace=Everything;size=L;root=PixelPhase1/ClusterShape/PXBarrel;focus=PixelPhase1/ClusterShape/PXBarrel/shapeFilterInner_PXLayer_1;zoom=yes;

here
black is Data ~~this PR~~ previous state of the PR
blue is Data: the reference (93X IB)
orange: MC reference
red: MC with 1+2
purple: MC this PR (1+2+3)

DATA is SingleMuon run 300631 LS 205.
this is an average representative Run2017C that happens to have similar PU than MC
MC the usual ttbar 35PU

VinInn · 2017-08-25T06:48:56Z

Cluster Shape Filter output applied to all clusters on track:
Obviously more clusters passes the cut...
Note the huge difference Data MC

VinInn · 2017-08-25T06:51:13Z

more quads less triplets
MC is in another planet...

VinInn · 2017-08-25T07:01:22Z

can we say anything about the quality of the tracks?
in data there seems to be more HP tracks

more short tracks (here absolute numbers as events are the same)
not necessarely good

more BPIX1 hits associated to tracks

VinInn · 2017-08-25T07:12:17Z

Once can have a look to MVA output

Data and MC do not always agree
the main difference between reference and this PR is in

in the overlap region where the MVA is clearly lower...
see also

this is most probably due to two effects:
a) more good tracks found as quads
b) less good tracks found relaxing the BPIX1 filter
note that the MC shows a similar effect (same plot normalized to enhance MC)

On the other hand we know that long clusters are split: so either we cut tight and loose tracks,
or cut loose and get more combinatorics...

VinInn · 2017-08-25T07:18:41Z

Conclusion by TRK-POG:
This is the best we can do at the moment.
It most probably improves data in the central region.
In the forward it is collecting more short clusters producing same more combinatorics and eventually fakes (mainly short track)
MC is irrelevant as it does not reproduce data at the level to be relevant in any comparison or guidance.

VinInn · 2017-08-25T07:19:30Z

@venturia @veszpv @boudoul

cmsbuild · 2017-08-25T07:21:15Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-08-25T07:21:15Z

Pull request #20269 was updated. @perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please check and sign again.

VinInn · 2017-08-25T07:21:54Z

@cmsbuild , please test

cmsbuild · 2017-08-25T07:22:08Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22487/console Started: 2017/08/25 09:22

cmsbuild · 2017-08-25T12:02:45Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20269/22489/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 1708 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2653934
DQMHistoTests: Total failures: 6460
DQMHistoTests: Total nulls: 2
DQMHistoTests: Total successes: 2647283
DQMHistoTests: Total skipped: 189
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 14 edm output root files, 26 DQM output files

slava77 · 2017-08-25T13:29:55Z

On 8/25/17 2:43 AM, Vincenzo Innocente wrote: Conclusion: we have just relaxed the filter for BPIX1 and things seems reasonable, still we cannot exclude that most of the recovered tracks are of low-quality (fakes)

As a quick check for this I usually check the KShort mass plot. (although it's perhaps more appropriate for more outer iterations)

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20269 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbvTPXeGCmRJsMAXXZInITyo-yG_cks5sbpdMgaJpZM4PCR1c>.

VinInn · 2017-08-25T13:48:36Z

yes K0, I was thinking to post them
here

lambdas

here MC for current Pr
http://innocent.home.cern.ch/innocent/RelVal/DQM_V0001_R000000001__RelValTTBAR35__CMSSW_9_3_X__CSFtrim1/plots_K0/mass.pdf
for previous
http://innocent.home.cern.ch/innocent/RelVal/DQM_V0001_R000000001__RelValTTBAR35__CMSSW_9_3_X__CSFtrim2/plots_K0/mass.pdf

and finally here data and MC normalized (mc reference and current PR as red and purple)

VinInn · 2017-08-25T13:51:18Z

btw the Non pixel (lxy>16) are here

VinInn · 2017-08-25T13:55:47Z

log scale, data-only, absolute normalization (current PR is orange, reference is blue)

Martin-Grunewald · 2017-08-29T11:35:30Z

+1

VinInn · 2017-09-01T10:16:52Z

more info timing:
this is for jetHT Run 298853, LumiSection 107

reference

[innocent@vinzen0 run2017]$ grep Cand oriHT.log | grep Time
TimeReport   0.002259     0.002259     0.002259  convTrackCandidates
TimeReport   0.041923     0.041923     0.041923  detachedQuadStepTrackCandidates
TimeReport   0.788025     0.788025     0.788025  detachedTripletStepTrackCandidates
TimeReport   0.026284     0.026284     0.026284  duplicateTrackCandidates
TimeReport   0.023188     0.023188     0.023188  generalV0Candidates
TimeReport   0.296770     0.296770     0.296770  highPtTripletStepTrackCandidates
TimeReport   0.102435     0.102435     0.102435  initialStepTrackCandidates
TimeReport   0.082164     0.082164     0.082164  initialStepTrackCandidatesPreSplitting
TimeReport   9.453527     9.453527     9.453527  jetCoreRegionalStepTrackCandidates
TimeReport   0.242869     0.242869     0.242869  lowPtQuadStepTrackCandidates
TimeReport   0.354679     0.354679     0.354679  lowPtTripletStepTrackCandidates
TimeReport   0.019023     0.019023     0.019023  mixedTripletStepTrackCandidates
TimeReport   0.001301     0.001301     0.001301  muonSeededTrackCandidatesInOut
TimeReport   0.000069     0.000069     0.000069  muonSeededTrackCandidatesOutIn
TimeReport   0.352298     0.352298     0.352298  pixelLessStepTrackCandidates
TimeReport   0.090384     0.090384     0.090384  pixelPairStepTrackCandidates
TimeReport   0.151290     0.151290     0.151290  tobTecStepTrackCandidates
[innocent@vinzen0 run2017]$ grep "Time Summary" -A10 oriHT.log
 Time Summary: 
 - Min event:   0.068701
 - Max event:   332.147
 - Avg event:   14.8299
 - Total loop:  2007.3
 - Total job:   2010.07
 Event Throughput: 0.498182 ev/s
 CPU Summary: 
 - Total loop:  15114.5
 - Total job:   15117.2

this PR

[innocent@vinzen0 run2017]$ grep Cand newpcsfHT.log | grep Time
TimeReport   0.002402     0.002402     0.002402  convTrackCandidates
TimeReport   0.049926     0.049926     0.049926  detachedQuadStepTrackCandidates
TimeReport   1.031765     1.031765     1.031765  detachedTripletStepTrackCandidates
TimeReport   0.027885     0.027885     0.027885  duplicateTrackCandidates
TimeReport   0.024351     0.024351     0.024351  generalV0Candidates
TimeReport   0.321789     0.321789     0.321789  highPtTripletStepTrackCandidates
TimeReport   0.121713     0.121713     0.121713  initialStepTrackCandidates
TimeReport   0.101549     0.101549     0.101549  initialStepTrackCandidatesPreSplitting
TimeReport   5.929064     5.929064     5.929064  jetCoreRegionalStepTrackCandidates
TimeReport   0.306078     0.306078     0.306078  lowPtQuadStepTrackCandidates
TimeReport   0.428532     0.428532     0.428532  lowPtTripletStepTrackCandidates
TimeReport   0.017785     0.017785     0.017785  mixedTripletStepTrackCandidates
TimeReport   0.001302     0.001302     0.001302  muonSeededTrackCandidatesInOut
TimeReport   0.000072     0.000072     0.000072  muonSeededTrackCandidatesOutIn
TimeReport   0.337323     0.337323     0.337323  pixelLessStepTrackCandidates
TimeReport   0.124470     0.124470     0.124470  pixelPairStepTrackCandidates
TimeReport   0.148559     0.148559     0.148559  tobTecStepTrackCandidates
[innocent@vinzen0 run2017]$ grep "Time Summary" -A10 newpcsfHT.log
 Time Summary: 
 - Min event:   0.0708599
 - Max event:   391.382
 - Avg event:   11.9243
 - Total loop:  1626.13
 - Total job:   1629.05
 Event Throughput: 0.614955 ev/s
 CPU Summary: 
 - Total loop:  12130.8
 - Total job:   12133.7

slava77 · 2017-09-01T12:41:22Z

TimeReport 9.453527 9.453527 9.453527 jetCoreRegionalStepTrackCandidates

vs

TimeReport 5.929064 5.929064 5.929064 jetCoreRegionalStepTrackCandidates

is this real or just a single event variation?

VinInn · 2017-09-01T12:52:46Z

non single event as Max event is larger and the total difference in timing is larger than MaxEvent...
It is true that JetHT seems to be dominated by tails, so most probably is due to "better" tails.
Need to be verified with another sample (can run on 4LS events instead of 1)

slava77 · 2017-09-01T13:35:14Z

If the per-event-per-module times are available, it should be possible
to quickly see if it's ~1 event [~fluctuation] or more than 10 [~average
change] that drive the average down.

[and I keep forgetting that my emails do not make it to the github threads anymore .. and github support did not respond since yesterday]

VinInn · 2017-09-02T10:58:53Z

this is for the full file 4LS ~4K events

reference

[innocent@vinzen0 run2017]$ grep Cand oriHTfull.log | grep Time
TimeReport   0.002346     0.002346     0.002346  convTrackCandidates
TimeReport   0.042465     0.042465     0.042465  detachedQuadStepTrackCandidates
TimeReport   0.774721     0.774721     0.774721  detachedTripletStepTrackCandidates
TimeReport   0.026070     0.026070     0.026070  duplicateTrackCandidates
TimeReport   0.022754     0.022754     0.022754  generalV0Candidates
TimeReport   0.295780     0.295780     0.295780  highPtTripletStepTrackCandidates
TimeReport   0.102527     0.102527     0.102527  initialStepTrackCandidates
TimeReport   0.083810     0.083810     0.083810  initialStepTrackCandidatesPreSplitting
TimeReport  10.463422    10.463422    10.463422  jetCoreRegionalStepTrackCandidates
TimeReport   0.242852     0.242852     0.242852  lowPtQuadStepTrackCandidates
TimeReport   0.351879     0.351879     0.351879  lowPtTripletStepTrackCandidates
TimeReport   0.018706     0.018706     0.018706  mixedTripletStepTrackCandidates
TimeReport   0.001347     0.001347     0.001347  muonSeededTrackCandidatesInOut
TimeReport   0.000072     0.000072     0.000072  muonSeededTrackCandidatesOutIn
TimeReport   0.344795     0.344795     0.344795  pixelLessStepTrackCandidates
TimeReport   0.090102     0.090102     0.090102  pixelPairStepTrackCandidates
TimeReport   0.148940     0.148940     0.148940  tobTecStepTrackCandidates
[innocent@vinzen0 run2017]$ grep "Time Summary" -A10  oriHTfull.log 
 Time Summary: 
 - Min event:   0.074085
 - Max event:   458.607
 - Avg event:   15.773
 - Total loop:  8436.98
 - Total job:   8440.89
 Event Throughput: 0.453243 ev/s
 CPU Summary: 
 - Total loop:  62056.1
 - Total job:   62059.9

this PR

[innocent@vinzen0 run2017]$ grep Cand newpcsfHTfull.log | grep Time
TimeReport   0.002498     0.002498     0.002498  convTrackCandidates
TimeReport   0.050875     0.050875     0.050875  detachedQuadStepTrackCandidates
TimeReport   1.031797     1.031797     1.031797  detachedTripletStepTrackCandidates
TimeReport   0.027217     0.027217     0.027217  duplicateTrackCandidates
TimeReport   0.024184     0.024184     0.024184  generalV0Candidates
TimeReport   0.324315     0.324315     0.324315  highPtTripletStepTrackCandidates
TimeReport   0.123354     0.123354     0.123354  initialStepTrackCandidates
TimeReport   0.104526     0.104526     0.104526  initialStepTrackCandidatesPreSplitting
TimeReport   6.971183     6.971183     6.971183  jetCoreRegionalStepTrackCandidates
TimeReport   0.311238     0.311238     0.311238  lowPtQuadStepTrackCandidates
TimeReport   0.430878     0.430878     0.430878  lowPtTripletStepTrackCandidates
TimeReport   0.017810     0.017810     0.017810  mixedTripletStepTrackCandidates
TimeReport   0.001346     0.001346     0.001346  muonSeededTrackCandidatesInOut
TimeReport   0.000073     0.000073     0.000073  muonSeededTrackCandidatesOutIn
TimeReport   0.332859     0.332859     0.332859  pixelLessStepTrackCandidates
TimeReport   0.125867     0.125867     0.125867  pixelPairStepTrackCandidates
TimeReport   0.147815     0.147815     0.147815  tobTecStepTrackCandidates
[innocent@vinzen0 run2017]$ grep "Time Summary" -A10 newpcsfHTfull.log 
 Time Summary: 
 - Min event:   0.0385249
 - Max event:   452.995
 - Avg event:   12.8815
 - Total loop:  7013.95
 - Total job:   7016.64
 Event Throughput: 0.545199 ev/s
 CPU Summary: 
 - Total loop:  50478.8
 - Total job:   50481.5

VinInn · 2017-09-02T11:02:33Z

and This is for the first 20 events

reference

[innocent@vinzen0 run2017]$ grep jetCoreRegionalStepTrackCandidates oriHT10e.log
TimeModule> 47262168 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 58.1212
TimeModule> 47494600 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 3.31402e-05
TimeModule> 47548909 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 1.32515
TimeModule> 47569353 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 0.620948
TimeModule> 46994700 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 3.29018e-05
TimeModule> 47178073 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 3.50475e-05
TimeModule> 47150038 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 0.987785
TimeModule> 47639432 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 3.79086e-05
TimeModule> 47182745 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 0.256188
TimeModule> 47366706 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 3.21865e-05
TimeModule> 47004110 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 0.335754
TimeModule> 47511606 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 3.40939e-05
TimeModule> 47109818 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 3.40939e-05
TimeModule> 47060757 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 188.254
TimeModule> 47577019 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 0.017673
TimeModule> 47032730 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 77.1136
TimeModule> 47400647 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 1.3013
TimeModule> 47415832 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 3.40939e-05
TimeModule> 47320641 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 6.26624
TimeModule> 47618480 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 3.19481e-05

this PR

TimeModule> 47262168 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 0.067265
TimeModule> 47494600 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 3.38554e-05
TimeModule> 47548909 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 1.33231
TimeModule> 47569353 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 0.598112
TimeModule> 46994700 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 3.40939e-05
TimeModule> 47178073 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 3.29018e-05
TimeModule> 47150038 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 0.975194
TimeModule> 47639432 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 3.38554e-05
TimeModule> 47182745 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 0.256285
TimeModule> 47366706 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 3.31402e-05
TimeModule> 47004110 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 0.331015
TimeModule> 47511606 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 3.29018e-05
TimeModule> 47109818 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 3.40939e-05
TimeModule> 47060757 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 186.748
TimeModule> 47577019 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 0.0172679
TimeModule> 47032730 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 76.5334
TimeModule> 47400647 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 1.29133
TimeModule> 47415832 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 3.50475e-05
TimeModule> 47320641 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 6.21745
TimeModule> 47618480 298853 jetCoreRegionalStepTrackCandidates CkfTrackCandidateMaker 3.38554e-05

VinInn · 2017-09-02T11:13:07Z

To be clear "the goal of this PR is NOT to mitigate the timing tails of jetcore". It is a side effect that can give clues where to further act on jet core.
still It is a non negligible fact (most probably dominated by few suspicious events) to be confirmed on more recent runs...

slava77 · 2017-09-02T13:56:29Z

I was looking around at the comparisons in data (as provided in #20269 (comment))
There is a csftrim only for /SingleMuon/CMSSW_9_3_X/csftrim
It would be interesting for me to see the JetHT as well.
Please upload a DQM for that as well.

[an input to the DQM developments]
NumberOfSeeds_jetCoreRegionalStepSeeds_jetCoreRegionalStep
has a range from 0 to 15
this is the same as https://goo.gl/vzQD3w
the range should be wider

perrotta · 2017-09-05T08:31:43Z

Verified on wf 10224 that propagation to higher level quantities of this PR is not giving particular issues. Of course, there is effect on jets, met, egamma, btag, but distributions are not disrupted or worsened. E.g. bTag (red is this PR, black is 930pre5):

perrotta · 2017-09-05T08:40:46Z

Timing and disk occupancy, evaluated with the same reference MC wf 10224 (high PU TTbar) are quite reasonable.

CPU time is compatible with only being slightly affected (largest differences wrt 930pre5, not all of them are significant):
delta/mean delta/orJob original new module name
+0.041088 +0.07% 109.94 ms/ev -> 114.55 ms/ev lowPtTripletStepTrackCandidates
+0.037298 +0.07% 124.69 ms/ev -> 129.43 ms/ev lowPtQuadStepTrackCandidates
+0.031567 +0.05% 116.73 ms/ev -> 120.47 ms/ev highPtTripletStepTrackCandidates
+0.023120 +0.03% 99.12 ms/ev -> 101.44 ms/ev particleFlowDisplacedVertex
+0.022104 +0.04% 135.88 ms/ev -> 138.92 ms/ev initialStepTrackCandidatesPreSplitting
+0.018342 +0.08% 307.32 ms/ev -> 313.00 ms/ev pixelLessStepTrackCandidates
-0.014709 -0.03% 147.86 ms/ev -> 145.70 ms/ev pixelLessStepHitTriplets
+0.014484 +0.03% 163.40 ms/ev -> 165.79 ms/ev initialStepTrackCandidates
+0.011852 +0.02% 117.76 ms/ev -> 119.17 ms/ev tobTecStepTrackCandidates

Job total: 6.83452 s/ev ==> 6.85637 s/ev

EventSize (size increase for all reco branches is below 0.1%):
883.1 -> 895.5 12 1.4 0.00 recoConversions_uncleanedOnlyAllConversions__RECO.
2217.0 -> 2272.6 56 2.5 0.00 recoConversions_allConversions__RECO.
1088.2 -> 1153.2 65 5.8 0.00 recoTrackExtras_ckfInOutTracksFromConversions__RECO.
94988.5 -> 95416.9 428 0.4 0.02 recoTracks_generalTracks__RECO.
82874.0 -> 83031.7 158 0.2 0.01 TrackingRecHitsOwned_generalTracks__RECO.
69296.9 -> 69326.5 30 0.0 0.00 recoPFCandidates_particleFlow__RECO.
198.2 -> 204.9 7 3.4 0.00 recoConversions_conversions__RECO.
447.9 -> 476.7 29 6.2 0.00 recoTracks_ckfInOutTracksFromConversions__RECO.
3170.2 -> 3187.1 17 0.5 0.00 floats_generalTracks_MVAValues_RECO.
452936.0 -> 454215.0 1279 0.3 0.05 recoTrackExtras_generalTracks__RECO.

2341434 -> 2343583 2149 0.1 ALL BRANCHES

perrotta · 2017-09-05T08:44:14Z

+1

Tracking quantities satisfy the expectations of the tracking POG
Propagation to the higher level objects doesn't show issues
Performance evaluated on data (Tune Pixel Cluster Shape Filter to mitigate BPIX1 inefficiency #20269 (comment)) and on the reference TTbar PU MC sample (Tune Pixel Cluster Shape Filter to mitigate BPIX1 inefficiency #20269 (comment)) are also satisfactory

cmsbuild · 2017-09-05T08:44:31Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

davidlange6 · 2017-09-05T14:32:38Z

+1

VinInn added 2 commits August 24, 2017 16:53

use 99.9% for L1, use 2,3,4 for quads

eb71fd9

change HLT as well

87295af

cmsbuild added this to the CMSSW_9_3_X milestone Aug 25, 2017

cmsbuild added code-checks-pending comparison-pending hlt-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Aug 25, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 25, 2017

change PR number

886be65

cmsbuild added code-checks-pending and removed code-checks-approved labels Aug 25, 2017

cmsbuild added comparison-available and removed comparison-pending labels Aug 25, 2017

cmsbuild added hlt-approved and removed hlt-pending labels Aug 29, 2017

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Sep 5, 2017

cmsbuild added orp-approved and removed orp-pending labels Sep 5, 2017

cmsbuild merged commit 231d62f into cms-sw:master Sep 5, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tune Pixel Cluster Shape Filter to mitigate BPIX1 inefficiency #20269

Tune Pixel Cluster Shape Filter to mitigate BPIX1 inefficiency #20269

VinInn commented Aug 25, 2017 •

edited

cmsbuild commented Aug 25, 2017

cmsbuild commented Aug 25, 2017

VinInn commented Aug 25, 2017

cmsbuild commented Aug 25, 2017

VinInn commented Aug 25, 2017 •

edited

VinInn commented Aug 25, 2017

VinInn commented Aug 25, 2017

VinInn commented Aug 25, 2017

VinInn commented Aug 25, 2017

VinInn commented Aug 25, 2017 •

edited

VinInn commented Aug 25, 2017

cmsbuild commented Aug 25, 2017

cmsbuild commented Aug 25, 2017

VinInn commented Aug 25, 2017

cmsbuild commented Aug 25, 2017 •

edited

cmsbuild commented Aug 25, 2017

slava77 commented Aug 25, 2017 via email

VinInn commented Aug 25, 2017 •

edited

VinInn commented Aug 25, 2017

VinInn commented Aug 25, 2017 •

edited

Martin-Grunewald commented Aug 29, 2017

VinInn commented Sep 1, 2017

slava77 commented Sep 1, 2017

VinInn commented Sep 1, 2017

slava77 commented Sep 1, 2017

VinInn commented Sep 2, 2017

VinInn commented Sep 2, 2017 •

edited

VinInn commented Sep 2, 2017 •

edited

slava77 commented Sep 2, 2017

perrotta commented Sep 5, 2017

perrotta commented Sep 5, 2017

perrotta commented Sep 5, 2017

cmsbuild commented Sep 5, 2017

davidlange6 commented Sep 5, 2017

Tune Pixel Cluster Shape Filter to mitigate BPIX1 inefficiency #20269

Tune Pixel Cluster Shape Filter to mitigate BPIX1 inefficiency #20269

Conversation

VinInn commented Aug 25, 2017 • edited

cmsbuild commented Aug 25, 2017

cmsbuild commented Aug 25, 2017

VinInn commented Aug 25, 2017

cmsbuild commented Aug 25, 2017

VinInn commented Aug 25, 2017 • edited

VinInn commented Aug 25, 2017

VinInn commented Aug 25, 2017

VinInn commented Aug 25, 2017

VinInn commented Aug 25, 2017

VinInn commented Aug 25, 2017 • edited

VinInn commented Aug 25, 2017

cmsbuild commented Aug 25, 2017

cmsbuild commented Aug 25, 2017

VinInn commented Aug 25, 2017

cmsbuild commented Aug 25, 2017 • edited

cmsbuild commented Aug 25, 2017

slava77 commented Aug 25, 2017 via email

VinInn commented Aug 25, 2017 • edited

VinInn commented Aug 25, 2017

VinInn commented Aug 25, 2017 • edited

Martin-Grunewald commented Aug 29, 2017

VinInn commented Sep 1, 2017

slava77 commented Sep 1, 2017

VinInn commented Sep 1, 2017

slava77 commented Sep 1, 2017

VinInn commented Sep 2, 2017

VinInn commented Sep 2, 2017 • edited

VinInn commented Sep 2, 2017 • edited

slava77 commented Sep 2, 2017

perrotta commented Sep 5, 2017

perrotta commented Sep 5, 2017

perrotta commented Sep 5, 2017

cmsbuild commented Sep 5, 2017

davidlange6 commented Sep 5, 2017

VinInn commented Aug 25, 2017 •

edited

VinInn commented Aug 25, 2017 •

edited

VinInn commented Aug 25, 2017 •

edited

cmsbuild commented Aug 25, 2017 •

edited

VinInn commented Aug 25, 2017 •

edited

VinInn commented Aug 25, 2017 •

edited

VinInn commented Sep 2, 2017 •

edited

VinInn commented Sep 2, 2017 •

edited