Updated DQM after front-end optimization 9_2_X #20299
Conversation
|
A new Pull Request was created by @nminafra (Nicola Minafra) for CMSSW_9_2_X. It involves the following packages: DQM/CTPPS @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
backport of #20270 |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
-1 Tested at: 5c8d3a6 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: ClangBuild
I found a compilation error while trying to compile with clang: void endRun(edm::Run const& run, edm::EventSetup const& eSetup);
^
/cvmfs/cms-ib.cern.ch/nweek-02490/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-09-19-1100/src/FWCore/Framework/interface/stream/EDAnalyzerBase.h:70:20: note: overridden virtual function is here
virtual void endRun(edm::Run const&, edm::EventSetup const&) {}
^
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-09-19-1100/src/DQM/CTPPS/plugins/CTPPSDiamondDQMSource.cc:576:128: error: expected '>'
if ( ( static_cast( ( optorx.getLV1() & 0xFF )-status.getEC() ) != EC_difference_56_ ) && ( static_cast( ( optorx.getLV1() & 0xFF )-status.getEC() ) < 128 ) )
^
>
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-09-19-1100/src/DQM/CTPPS/plugins/CTPPSDiamondDQMSource.cc:576:119: note: to match this '<'
if ( ( static_cast( ( optorx.getLV1() & 0xFF )-status.getEC() ) != EC_difference_56_ ) && ( static_cast( ( optorx.getLV1() & 0xFF )-status.getEC() ) < 128 ) )
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Pull request #20299 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
merge |
This PR updates the DQM according to the latest hardware configuration.
9_2_X backport of PR 20270.
The front-end chip (HPTDC) configuration has been optimized during the commissioning of the detector.
The main modification was the introduction of a delay (digital) for the different channels to temporally align them. This allows a better visualization of the online data: for instance all peaks in the leading edge plots are aligned.
Therefore, it was possible to reduce the acquisition window from 5 clock cycle down to 2. Drastically reducing the possibility of 2 hits in the same event.
Out of those 5 time slices, the one synchronized with the trigger (centralOOT) was moved from 4 to 1 and then to 0 (first acquired slice).
Some parameters require the modification of the DQM code; moreover, the readability of some plots has been improved (showing percentage instead of absolute values) and some new plots have been introduced, as the hit map in the last lumisection to immediately spot problems with the detectors.
Also, code has been improved (switch case removed, NULL -> nullptr, histogram binning optimized).
Finally, this code is compatible with the upcoming geometry update (UFSD implementation).
Note about urgency: current version of the DQM is enough to understand if the detector is working, but not enough to show its performance online.