Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sequence for HLTDQM only step on AOD #20322

Merged
merged 1 commit into from Sep 8, 2017
Merged

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Aug 30, 2017

add a new sequence offlineHLTSourceOnAOD
which is meant to be used via cmsDriver command, like -s DQM:offlineHLTSourceOnAOD,
for running the HLT DQM on AOD files
(w/o the need of running the RECO step on the fly)

the standard sequence offlineHLTSource used by almost all the workflows w/ the DQM step
is now defined as the sum of
the offlineHLTSourceOnAOD one
plus the modules/sequences which need to access to transient collections
(for instance the HCAL monitoring hcalMonitoringSequence and jetMETHLTOfflineAnalyzer)

no differences w.r.t. current DQM are expected

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for master.

It involves the following packages:

DQMOffline/Trigger

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@battibass, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@mtosi
Copy link
Contributor Author

mtosi commented Aug 30, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 30, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22602/console Started: 2017/08/30 21:29

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20322/401

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20322/22602/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2653934
  • DQMHistoTests: Total failures: 202
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2653543
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

mtosi added a commit to mtosi/cmssw that referenced this pull request Sep 4, 2017
@smuzaffar smuzaffar modified the milestones: CMSSW_9_4_X, CMSSW_9_3_X Sep 6, 2017
@davidlange6
Copy link
Contributor

for this to work for more than a few releases, it needs a test in runTheMatrix - @fabozzi could you look into doing that with @mtosi ?

@fabozzi
Copy link
Contributor

fabozzi commented Sep 6, 2017

ok, we will follow-up with Mia for that

@mtosi
Copy link
Contributor Author

mtosi commented Sep 6, 2017 via email

@mtosi
Copy link
Contributor Author

mtosi commented Sep 7, 2017

I'm using it by doing the following

cmsDriver.py hltdqm -s DQM:offlineHLTSourceOnAOD --conditions=92X_dataRun2_Prompt_v8 --geometry DB:Extended --eventcontent DQM --datatier DQMIO --data --era Run2_2017 --filetype=EDM --filein root://eoscms.cern.ch//eos/cms/tier0/store/da
ta/Run2017D/HLTPhysics/AOD/PromptReco-v1/000/302/043/00000/CA7873CD-678F-E711-9376-02163E01429E.root -n 100 --fileout DQM_onlyHLT.root

@davidlange6
Copy link
Contributor

hi @mtosi - right - but if this functionality is not tested regularly it will break. So having a simple cmsDriver that reads aod and runs this sequence each IB means that any problems will be caught and reported. you cmsDriver is whats needed by @fabozzi. thx.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0561d1e into cms-sw:master Sep 8, 2017
cmsbuild added a commit that referenced this pull request Oct 17, 2017
add sequence for HLTDQM only step on AOD [backport of #20322]
mtosi added a commit to mtosi/cmssw that referenced this pull request Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants