Hcal validation fix for digi (for Phase2 Barrel) & Chi2 Fix (avoid nan)

[hatakeyamak]

• QIE11 digi validation was added to only to HE and not to HB yet, given that HB phase1 is still not there yet, but this is not good for phase2 barrel validation
• Method2 chi2 plots were showing nan due to log10 of negative chi2 (when fit fails). Added a protection.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

A new Pull Request was created by @hatakeyamak (Kenichi Hatakeyama) for master.

It involves the following packages:

DQMOffline/Hcal
Validation/HcalDigis

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20340/435

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20340/435/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20340/435/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly (this will soon be required for PRs to be considered)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

Pull request #20340 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20340/436

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

Pull request #20340 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20340/437

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22646/console Started: 2017/09/01 15:06

[cmsbuild]

+1
Tested at: 095dc96
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20340/22646/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
94fab3e
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20340/22646/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20340/22646/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20340/22646/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2656041
• DQMHistoTests: Total failures: 454
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2655398
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[dmitrijus]

+1
(also, if possible, please fill in the description)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1