Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --parent option in hltGetConfiguration script (93X) #20347

Merged
merged 1 commit into from
Sep 4, 2017

Conversation

Martin-Grunewald
Copy link
Contributor

Fix --parent option in hltGetConfiguration script (93X).
Based on CMSSW_9_3_0_pre4

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @geoff-smith, @jalimena this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

type bug-fix

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22649/console Started: 2017/09/01 16:52

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20347/449

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20347/22649/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2656041
  • DQMHistoTests: Total failures: 219
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2655633
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 84e3ffc into cms-sw:master Sep 4, 2017
@Martin-Grunewald Martin-Grunewald deleted the 93XparentOption branch April 27, 2018 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants