btag@HLT paths modification to be consistent with the new HLT menu #20359
Conversation
|
The code-checks are being triggered in jenkins. |
|
A new Pull Request was created by @natalia-korneeva (Natalia Korneeva) for master. It involves the following packages: HLTriggerOffline/Btag @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+code-checks |
| 'HLT_PFHT380_SixJet32_DoubleBTagCSV_', | ||
| 'HLT_PFMET120_PFMHT120_IDTight_v', | ||
| 'HLT_PFHT300PT30_QuadPFJet_75_60_45_40_v', | ||
| 'HLT_PFHT380_SixPFJet32_DoublePFBTagCSV_', |
There was a problem hiding this comment.
shouldn't be
HLT_PFHT380_SixPFJet32_DoublePFBTagCSV_v
?
| @@ -4,7 +4,7 @@ | |||
| #denominator trigger | |||
| hltBtagTriggerSelection = cms.EDFilter( "TriggerResultsFilter", | |||
| triggerConditions = cms.vstring( | |||
| "HLT_PFMET120_* OR HLT_HT300PT30_QuadJet_75_60_45_40_v* OR HLT_PFHT380_SixJet32_DoubleBTagCSV_* OR HLT_Ele28_eta2p1_WPTight_Gsf_HT150_* OR HLT_IsoMu24_eta2p1_*"), | |||
| "HLT_PFMET120_PFMHT120_IDTight_v* OR HLT_PFHT300PT30_QuadPFJet_75_60_45_40_v* OR HLT_PFHT380_SixPFJet32_DoublePFBTagCSV_* OR HLT_Ele28_eta2p1_WPTight_Gsf_HT150_* OR HLT_IsoMu24_eta2p1_v*"), | |||
There was a problem hiding this comment.
shouldn't it be
HLT_PFHT380_SixPFJet32_DoublePFBTagCSV_v
| 'HLT_PFHT300PT30_QuadPFJet_75_60_45_40_v', | ||
| 'HLT_PFHT300PT30_QuadPFJet_75_60_45_40_v', | ||
| 'HLT_PFHT300PT30_QuadPFJet_75_60_45_40_v', | ||
| 'HLT_PFHT380_SixPFJet32_DoublePFBTagCSV_', |
There was a problem hiding this comment.
shouldn't it be
HLT_PFHT380_SixPFJet32_DoublePFBTagCSV_v
There was a problem hiding this comment.
was this question resolved? @natalia-korneeva
There was a problem hiding this comment.
@davidlange6 yes as @mtosi agrees with my point and doesn't insist on finishing with _v
| 'HLT_PFHT380_SixJet32_DoubleBTagCSV_', | ||
| 'HLT_PFMET120_PFMHT120_IDTight_v', | ||
| 'HLT_PFHT300PT30_QuadPFJet_75_60_45_40_v', | ||
| 'HLT_PFHT380_SixPFJet32_DoublePFBTagCSV_', |
There was a problem hiding this comment.
shouldn't it be
HLT_PFHT380_SixPFJet32_DoublePFBTagCSV_v
| hltCombinedSecondaryVertexBJetTagsCalo | ||
|
|
||
| HLT_PFHT380_SixJet32_DoubleBTagCSV_: | ||
| HLT_PFHT380_SixPFJet32_DoublePFBTagCSV_: |
There was a problem hiding this comment.
shouldn't it be
HLT_PFHT380_SixPFJet32_DoublePFBTagCSV_v
| hltFastPrimaryVertex | ||
| hltFastPVPixelVertices | ||
| hltVerticesL3 | ||
|
|
||
| HLT_PFHT380_SixJet32_DoubleBTagCSV_: | ||
| HLT_PFHT380_SixPFJet32_DoublePFBTagCSV_: |
There was a problem hiding this comment.
shouldn't it be
HLT_PFHT380_SixPFJet32_DoublePFBTagCSV_v
There was a problem hiding this comment.
@mtosi in this case it should be HLT_PFHT380_SixPFJet32_DoublePFBTagCSV_2p2_v , but in the previous version it was HLT_PFHT380_SixJet32_DoubleBTagCSV_p075_v, so keeping in mind possible future changes I would leave this path as is (without 2p2_v)
| hltCombinedSecondaryVertexBJetTagsCalo | ||
|
|
||
| HLT_PFHT380_SixJet32_DoubleBTagCSV_: | ||
| HLT_PFHT380_SixPFJet32_DoublePFBTagCSV_: | ||
| hltCombinedSecondaryVertexBJetTagsCalo | ||
|
|
||
| HLT_Ele28_eta2p1_WPTight_Gsf_HT150_: |
There was a problem hiding this comment.
are you sure about this ?
shouldn't it be
HLT_Ele28_eta2p1_WPTight_Gsf_HT150_v
There was a problem hiding this comment.
Yes, there is only one HLT path that could be found with this pattern. To be more strict it is of course possible to add _v
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
did you test the config ?
are you sure you are selecting events ?
mia
…On Mon, Sep 4, 2017 at 11:45 AM, Natalia Korneeva ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In HLTriggerOffline/Btag/test/config.ini
<#20359 (comment)>:
> hltFastPrimaryVertex
hltFastPVPixelVertices
hltVerticesL3
-HLT_PFHT380_SixJet32_DoubleBTagCSV_:
+HLT_PFHT380_SixPFJet32_DoublePFBTagCSV_:
@mtosi <https://github.com/mtosi> in this case it should be
HLT_PFHT380_SixPFJet32_DoublePFBTagCSV_2p2_v , but in the previous
version it was HLT_PFHT380_SixJet32_DoubleBTagCSV_p075_v, so keeping in
mind possible future changes I would leave this path as is (without 2p2_v)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20359 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt58ylWj9olnp5ugcgpokSZrPEWLU7Dks5se8a9gaJpZM4PLNBV>
.
|
|
@mtosi yes, everything is fine, I've got all the histograms successfully filled. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
The code-checks are being triggered in jenkins. |
|
Pull request #20359 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again. |
|
+code-checks |
|
@cmsbuild, please test
…On Tue, Sep 5, 2017 at 4:56 PM, cmsbuild ***@***.***> wrote:
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20359/507
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20359 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt588Q-FmYgxPDQH-uZS09b5LQxN2Taks5sfWEBgaJpZM4PLNBV>
.
|
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Minor modification of names of HLT paths to monitor.