Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix QuickTrackAssociatorByHits for composite hits #20364

Merged
merged 5 commits into from
Sep 5, 2017
Merged

Fix QuickTrackAssociatorByHits for composite hits #20364

merged 5 commits into from
Sep 5, 2017

Commits on Aug 12, 2017

  1. using numberOfValidTrackClusters instead of numberOfValidTrackHits

    @ebrondol
    ebrondol committed Aug 12, 2017
    Configuration menu
    Copy the full SHA
    287c26a View commit details
    Browse the repository at this point in the history

  2. consistent nomenclature

    @ebrondol
    ebrondol committed Aug 12, 2017
    Configuration menu
    Copy the full SHA
    963631f View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2017

  1. In getDoubleCount, count the number of duplicate cluster->TP matches … 

    …instead of hits

Otherwise composite hits will always be treated as "duplicates".
    @makortel
    makortel committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    1a8c051 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2017

  1. Code style checks

    @makortel
    makortel committed Sep 4, 2017
    Configuration menu
    Copy the full SHA
    d3e1f4a View commit details
    Browse the repository at this point in the history

  2. For TrackerHitAssociator count denominator as hits 

    It counts the numerator also by hits. I agree it will be confusing to
understand when the association is done by hits and when by clusters.
    @makortel
    makortel committed Sep 4, 2017
    Configuration menu
    Copy the full SHA
    330377f View commit details
    Browse the repository at this point in the history