Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HGCAL calibration #20365

Merged
merged 8 commits into from
Sep 6, 2017
Merged

HGCAL calibration #20365

merged 8 commits into from
Sep 6, 2017

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Sep 4, 2017

This PR:

  • contains the first implementation of a calibration DQM module that is capable of monitoring the calibration correctness at several level: simClusters, hgcal multiclusters and electrons and photons. It is meant to be run on particle gun samples.
  • activates HGCAL validation code that is in the release but not linked to phaseII workflows.
  • adds an ancillary C++ code to plot two close-by showers, currently not linked to any workflow.

First implementation of a hit calibration DQM module that is
capable of monitoring the calibration correctness at several
level: simClusters, hgcal multiclusters and electrons and
photons. It is meant to be run on particle gun samples.
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

Validation/Configuration
Validation/HGCalValidation

@perrotta, @civanch, @vazzolini, @kmaeshima, @mdhildreth, @dmitrijus, @cmsbuild, @slava77, @vanbesien can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @swertz, @kpedro88, @lgray, @cseez, @bsunanda, @pfs this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20365/480

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22689/console Started: 2017/09/04 12:43

@rovere
Copy link
Contributor Author

rovere commented Sep 4, 2017

@felicepantaleo @malgeri

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20365/22689/summary.html

Comparison Summary:

  • You potentially added 961 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2656522
  • DQMHistoTests: Total failures: 207
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2656126
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Sep 4, 2017

assign upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

@dmitrijus
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

perrotta commented Sep 6, 2017

+1

  • Validation related PR: the updates to Validation/Configuration just add HGCal to the phaseII validation sequence

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 505e1cc into cms-sw:master Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants