Ecal pedestal PCL improvements : fix for Nans, added histos, added check, added exclusion of non-stabl… #20366
Conversation
…ebeam (off in config)
|
The code-checks are being triggered in jenkins. |
|
A new Pull Request was created by @argiro for master. It involves the following packages: Calibration/EcalCalibAlgos @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Improvements to Ecal pedestal PCL, as discussed at https://indico.cern.ch/event/661804/ |
argiro
changed the title
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20366/481 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20366/481/git-diff.patch You can run |
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20366/483 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20366/483/git-diff.patch You can run |
|
do I really have to add the keyword "override" ? I had to google it up ..
S.
… On 4 Sep 2017, at 14:35, cmsbuild ***@***.***> wrote:
-code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20366/483
Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20366/483/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20366/483/git-diff.patch | patch -p1
You can run scram build code-checks to apply code checks directly (this will soon be required for PRs to be considered)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
merge |
No description provided.