Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking region monitoring to tracking DQM #20378

Merged
merged 2 commits into from
Sep 5, 2017

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Sep 5, 2017

This PR adds simple monitoring of tracking regions to tracking DQM with the following quantities

  • number of regions
  • pT, eta, phi, and eta-vs-phi of candidates used to seed the regions

The monitoring is enabled only for jetCore iteration (the only offline iteration with candidate-seeded regions).

Tested in 9_3_0_pre5, expecting only new histograms and no changes to existing ones.

@rovere @VinInn @mtosi

…king regions

Region does not have "pT" so that requires using the candidates, so it
is more consistent to monitor the eta and phi of the candidates as
well. For the tracking region producers that also loop over vertices
this probably makes more sense, i.e. the eta and phi of the candidates
do not get multiplied by the vertex multiplicity of that event.
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

DQM/TrackingMonitor
DQM/TrackingMonitorSource

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@hdelanno, @threus, @fioriNTU, @idebruyn, @ebrondol, @mtosi this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20378/500

@makortel
Copy link
Contributor Author

makortel commented Sep 5, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22710/console Started: 2017/09/05 11:51

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20378/22710/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2656434
  • DQMHistoTests: Total failures: 211
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2656034
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2ec1c74 into cms-sw:master Sep 5, 2017
@makortel makortel deleted the trackingRegionsDQM branch February 12, 2018 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants