-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up hippy #20382
Clean up hippy #20382
Conversation
@smuzaffar do we need any backports? |
The code-checks are being triggered in jenkins. |
A new Pull Request was created by @hroskes (Heshy Roskes) for master. It involves the following packages: Alignment/HIPAlignmentAlgorithm @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks |
please test |
The tests are being triggered in jenkins. |
@ghellwig We will do this in another PR, not this one. This will potentially create mrege conflicts with a parallel development. All scripts are pretty unique in their name anyway (e.g. submitJobs_py), so the names are unlikely to cause harm, as they haven't done until now. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@davidlange6 , can we get this in 93X? This is just the removal of unused scripts with generic names e.g. |
merge |
@usarica, @ghellwig, @smuzaffar
delete some old scripts, to fix #20380. They were moved to a newer version, using
iterator_py
and friends, a long long time ago.The remaining files in Alignment/HIPAlignmentAlgorithm/scripts that haven't been modified since "Snapshot of CMSSW_6_2_0_pre8" are:
checkError.sh
: still workscompareGeomSerial_tpl.C
,serialGeomCompare.pl
- I doubt these work anymore, but if fixed they would be potentially useful. Since they're not hurting anyone I didn't delete them.runControl.csh
: still needed