Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up hippy #20382

Merged
merged 2 commits into from
Sep 6, 2017
Merged

Clean up hippy #20382

merged 2 commits into from
Sep 6, 2017

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Sep 5, 2017

@usarica, @ghellwig, @smuzaffar

delete some old scripts, to fix #20380. They were moved to a newer version, using iterator_py and friends, a long long time ago.

The remaining files in Alignment/HIPAlignmentAlgorithm/scripts that haven't been modified since "Snapshot of CMSSW_6_2_0_pre8" are:

  • checkError.sh: still works
  • compareGeomSerial_tpl.C, serialGeomCompare.pl - I doubt these work anymore, but if fixed they would be potentially useful. Since they're not hurting anyone I didn't delete them.
  • runControl.csh: still needed

@hroskes
Copy link
Contributor Author

hroskes commented Sep 5, 2017

@smuzaffar do we need any backports?

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

A new Pull Request was created by @hroskes (Heshy Roskes) for master.

It involves the following packages:

Alignment/HIPAlignmentAlgorithm

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20382/502

@smuzaffar
Copy link
Contributor

please test
thanks @hroskes for quick fix. Changes in master/93x is enough for now.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22719/console Started: 2017/09/05 15:56

@ghellwig
Copy link

ghellwig commented Sep 5, 2017

@hroskes as already pointed out to @usarica some time ago, I would in general recommend to rename hippy specific scripts that are in PATH like this: SCRIPT_NAME -> hippy_SCRIPT_NAME

@usarica
Copy link
Contributor

usarica commented Sep 5, 2017

@ghellwig We will do this in another PR, not this one. This will potentially create mrege conflicts with a parallel development. All scripts are pretty unique in their name anyway (e.g. submitJobs_py), so the names are unlikely to cause harm, as they haven't done until now.
@hroskes Please refrain from changing files that are already modified as part of alignment campaigns.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20382/22719/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2656434
  • DQMHistoTests: Total failures: 214
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2656031
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@smuzaffar
Copy link
Contributor

@davidlange6 , can we get this in 93X? This is just the removal of unused scripts with generic names e.g. configure

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 72fcaf9 into cms-sw:master Sep 6, 2017
@hroskes hroskes deleted the clean-up-hippy branch September 6, 2017 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid generic executable names in cmssw e.g. configure
6 participants