Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT Updates with L1T updates and tracker ideal alignment #20397

Merged
merged 2 commits into from Sep 11, 2017

Conversation

lpernie
Copy link
Contributor

@lpernie lpernie commented Sep 6, 2017

Summary of changes in Global Tags

RunII simulation

Upgrade

2017_MC

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

A new Pull Request was created by @lpernie (Luca) for master.

It involves the following packages:

Configuration/AlCa

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20397/521

@lpernie lpernie changed the title L1 and Tracker TAG in autocond GT Updates with L1T updates and tracker ideal alignment Sep 6, 2017
@lpernie
Copy link
Contributor Author

lpernie commented Sep 6, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22744/console Started: 2017/09/06 12:13

@ghellwig
Copy link

ghellwig commented Sep 6, 2017

@lpernie could you, for documentation purposes, please update the description to clarify that also the 2017 GTs have been updated?
I want to link your PR in a related HN thread and this would make it easier for the reader to digest your changes.

@lpernie
Copy link
Contributor Author

lpernie commented Sep 6, 2017

Yes, the script that print out the difference need to be updated. I'm on it and as soon this is done I will add a complete description. At the moment this is only partial.

@ghellwig
Copy link

ghellwig commented Sep 6, 2017

@lpernie thanks!

@lpernie
Copy link
Contributor Author

lpernie commented Sep 6, 2017

Done

@ghellwig
Copy link

ghellwig commented Sep 6, 2017

thanks, again :)

@ghellwig
Copy link

ghellwig commented Sep 6, 2017

@lpernie I think, this needs to be backported to 93X, now that master moved forward to 94X, right?

@lpernie
Copy link
Contributor Author

lpernie commented Sep 6, 2017

Yes indeed I'm on it. I was out for lunch.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20397/22744/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2656498
  • DQMHistoTests: Total failures: 215
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2656094
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

davidlange6 commented Sep 6, 2017 via email

@arunhep
Copy link
Contributor

arunhep commented Sep 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@makortel
Copy link
Contributor

makortel commented Sep 8, 2017

changes in this directory https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_9_3_X_2017-09-05-2300+20397/22309/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/PixelPhase1V.html are not because of changes in this PR. I have seen it in many other PRs.

So we have irreproducibility in pixel phase1 validation? FYI @fioriNTU, @boudoul, @veszpv

@VinInn
Copy link
Contributor

VinInn commented Sep 8, 2017

is this MC only?
reco is ok I assume
@venturia as well

@makortel
Copy link
Contributor

makortel commented Sep 8, 2017

@VinInn
Copy link
Contributor

VinInn commented Sep 8, 2017

ten lines of code...
https://cmssdt.cern.ch/lxr/source/Validation/SiPixelPhase1TrackingParticleV/src/SiPixelPhase1TrackingParticleV.cc

(
sorry for having hijacked this PR!!!
we may have to move to pixeloffline
)

@davidlange6
Copy link
Contributor

hi @lpernie - is there a summary of the motivation for the 2016 L1 changes? I've missed it.

@arunhep
Copy link
Contributor

arunhep commented Sep 11, 2017

@davidlange6
changes in 2016 GT are made on request of @kkotov to address the failures he got in PR #19456
the request has been made here https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/3188.html
I will let @kkotov comment more

@davidlange6
Copy link
Contributor

ok, thanks

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants