add option for sequential RootEmbeddedFileSequence to not recycle files #20403
Conversation
…ntial mode, and update spyEventMatching_cfg.py to use it
|
The code-checks are being triggered in jenkins. |
|
A new Pull Request was created by @dan131riley (Dan Riley) for master. It involves the following packages: DQM/SiStripMonitorHardware @smuzaffar, @Dr15Jones, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20403/527 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20403/527/git-diff.patch You can run |
|
The tests are being triggered in jenkins. |
cmsbuild
added
code-checks-rejected
tests-started
and removed
code-checks-pending
tests-pending
labels
|
@dan131riley or do you think adding a different interface to call which does not loop would be easier for code to deal with? A configuration option implies that the calling code could handle either behavior. An interface explicitly says only one behavior is expected. |
|
@Dr15Jones good question. The interface that's actually used is VectorInputSource::loopOverEvents(), and there's two use cases:
So changing the interface would mean adding interfaces to both RootEmbeddedFileSequence and VectorInputSource, maybe changing to something like which, after sketching it out, does look better. So I'll update the PR to do that, and you won't be able to spot the changes since it'll also have all the clang-tidy diffs... |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
…pset parameter; this touches FWCore/Sources/interface/VectorInputSource.h, so the changes are more intrusive than the pset hack
|
The tests are being triggered in jenkins. |
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-started
labels
|
The code-checks are being triggered in jenkins. |
|
Pull request #20403 was updated. @smuzaffar, @Dr15Jones, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien can you please check and sign again. |
|
+code-checks |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
merge |
PR #9091 changed the behavior of RootInputFileSequence (now re-factored into RootEmbeddedFileSequence) such that, in sequential mode, when the secondary source reaches the end of the last file it loops back to the beginning of the first file instead of halting. This makes sense for the primary use in the mixing module; however, SiStripSpyEventMatcher depends on the old behavior. This PR adds an option (recycleFiles, defaults to true) that restores the old behavior when turned off, and modifies the SiStripSpyEventMatcher cfi to set recycleFiles to false. Fixes issue #20361