Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to DQMServices/Core for new protobuf version. #20406

Merged
merged 1 commit into from Sep 16, 2017
Merged

Updates to DQMServices/Core for new protobuf version. #20406

merged 1 commit into from Sep 16, 2017

Conversation

gartung
Copy link
Member

@gartung gartung commented Sep 6, 2017

Needs to be used with protobuf update
cms-sw/cmsdist#3382

@cmsbuild cmsbuild added this to the CMSSW_9_4_X milestone Sep 6, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

DQMServices/Core

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented Sep 6, 2017

@smuzaffar
@davidlange6

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20406/530

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20406/530/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20406/530/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly (this will soon be required for PRs to be considered)

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#3382

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 11, 2017 •
edited

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3382
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22844/console

@cmsbuild cmsbuild mentioned this pull request Sep 11, 2017
Merged
@cmsbuild
Copy link
Contributor

+1
Tested at: 0a53620
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20406/22844/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4b929e5
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20406/22844/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20406/22844/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20406/22844/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2642440
  • DQMHistoTests: Total failures: 204
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2642047
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@dmitrijus
Copy link
Contributor

please test

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@dmitrijus
Copy link
Contributor

We will have to bump the fastHadd @p5 version once this merged, but this will be done anyway once we switch to 94x or higher.

@cmsbuild
Copy link
Contributor

-1

Tested at: 0a53620

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dfc38ed
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20406/22851/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20406/22851/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20406/22851/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

  • Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-11-1100/src/Utilities/StaticAnalyzers/src/murmur.c 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-11-1100/src/Utilities/StaticAnalyzers/src/dablooms.c 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-11-1100/src/DQMServices/Core/src/DQMService.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-11-1100/src/DQMServices/Core/src/ROOTFilePB.pb.cc 
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-11-1100/src/DQMServices/Core/src/ROOTFilePB.pb.cc:5:0:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-11-1100/src/DQMServices/Core/src/ROOTFilePB.pb.h:12:2: error: #error This file was generated by a newer version of protoc which is
 #error This file was generated by a newer version of protoc which is
  ^~~~~
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-11-1100/src/DQMServices/Core/src/ROOTFilePB.pb.h:13:2: error: #error incompatible with your Protocol Buffer headers. Please update
 #error incompatible with your Protocol Buffer headers.  Please update
  ^~~~~
  • Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-11-1100/src/DQMServices/Core/test/DQMTestStandaloneBuildOfDQMStore.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-11-1100/src/DQMServices/Core/test/DQMFastMatchTest.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-11-1100/src/DQMServices/Core/test/DQMQualityTestsExample.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-11-1100/src/DQMServices/Core/test/DQMBackEndInterfaceExample.cc 
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-11-1100/src/DQMServices/Core/src/ROOTFilePB.pb.cc:5:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-11-1100/src/DQMServices/Core/src/ROOTFilePB.pb.h:12:2: error: This file was generated by a newer version of protoc which is
#error This file was generated by a newer version of protoc which is
 ^
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-11-1100/src/DQMServices/Core/src/ROOTFilePB.pb.h:13:2: error: incompatible with your Protocol Buffer headers.  Please update
#error incompatible with your Protocol Buffer headers.  Please update
 ^

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
dfc38ed
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20406/22851/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20406/22851/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#3382

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 13, 2017 •
edited

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3382
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22949/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 0a53620
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20406/22949/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
8dd9a2c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20406/22949/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20406/22949/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20406/22949/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2646524
  • DQMHistoTests: Total failures: 217
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2646118
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@davidlange6 davidlange6 merged commit 08df120 into cms-sw:master Sep 16, 2017
@davidlange6 davidlange6 mentioned this pull request Sep 16, 2017
Merged
@gartung gartung deleted the DQMServices-Core-protobuf-3.4.0 branch September 27, 2017 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-rejected comparison-available dqm-approved fully-signed orp-pending requires-external tests-approved
Projects
None yet
Milestone
CMSSW_9_4_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gartung @cmsbuild @smuzaffar @dmitrijus @davidlange6