bug fixes for RHStopTracer (94X)

[jalimena]

This pull request is to fix two bugs that were introduced into the RHStopTracer module:

• First, the particle names need to be matched with a regular expression
• Secondly, we want to record a "stopped particle" if the particle name is matched OR if the energy of the particle is very high (not AND)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

A new Pull Request was created by @jalimena (Juliette Alimena) for master.

It involves the following packages:

SimG4Core/CustomPhysics

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[jalimena]

It would be best if this PR could be included before the 2017 MC v2 campaign is generated. I supposed that MC will be generated in 93X or 92X? Please advise me on which release to make a backport for.

FYI, the bugs I'm fixing here were introduced with this commit:
03066f9#diff-4488fe97595fa9ed431921070d47c43d

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20421/562

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20421/562/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20421/562/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly (this will soon be required for PRs to be considered)

[jalimena]

I should also mention that without these fixes, the code does not behave as expected and we never get any stopped particles.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

Pull request #20421 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20421/572

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22800/console Started: 2017/09/08 02:39

[cmsbuild]

+1
Tested at: 2b05323
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20421/22800/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c72da29
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20421/22800/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20421/22800/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

The code-checks are being triggered in jenkins.

[jalimena]

Hi @civanch and @davidlange6 , I think my last commit should address your latest comments.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20421/719

[cmsbuild]

Pull request #20421 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[civanch]

please test

[civanch]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23001/console Started: 2017/09/15 11:55

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: 933a7f0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20421/23001/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9f20abe
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20421/23001/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20421/23001/git-merge-result

[cmsbuild]

Comparison job queued.

[davidlange6]

+1

[davidlange6]

merge

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20421/23001/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2646869
• DQMHistoTests: Total failures: 207
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2646473
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files