New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix muon hit related info #20434
fix muon hit related info #20434
Conversation
A new Pull Request was created by @swagata87 (Swagata Mukherjee) for CMSSW_9_2_X. It involves the following packages: HLTrigger/Muon @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
We'd need a 94X PR for integration first! |
Ok, I created another PR for 94X here-> #20441 |
Please apply the scram build code checks fro the 94X PR also here! |
Pull request #20434 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
Comparison is ready Comparison Summary:
|
+1 |
Currently, the variable nMatchedStations is set to zero. And number of valid muon hits is accessed in a way that it always returns zero. As these 2 variables will be essential for the analysis that we plan to do using the dimuon scouting data, so I changed the code in a way that these variables returns meaningful value and save that in the event.