Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted test modules to global modules #20442

Merged
merged 1 commit into from Sep 10, 2017

Conversation

Dr15Jones
Copy link
Contributor

No description provided.

@Dr15Jones
Copy link
Contributor Author

ping

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Integration

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20442/594

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22821/console Started: 2017/09/08 20:34

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

-1

Tested at: 99c202b

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0561d1e
f1103f9
ee01ed6
9617bdf
76961d8
b1ede7a
cd0aacb
f204173
58af6f8
c72da29
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20442/22821/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20442/22821/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20442/22821/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-08-1100/src/TopQuarkAnalysis/Examples/plugins/TopGenEventAnalyzer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-08-1100/src/TopQuarkAnalysis/Examples/plugins/HypothesisAnalyzer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-08-1100/src/TopQuarkAnalysis/Examples/plugins/TopTauAnalyzer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-08-1100/src/TopQuarkAnalysis/Examples/plugins/TopMuonAnalyzer.cc 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-08-1100/src/CondCore/SiStripPlugins/plugins/SiStripDetVOff_PayloadInspector.cc: In member function 'virtual bool {anonymous}::SiStripDetVOffTest::fill(const std::vector, std::allocator > > >&)':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-08-1100/src/CondCore/SiStripPlugins/plugins/SiStripDetVOff_PayloadInspector.cc:171:22: error: no matching function for call to 'SiStripDetSummary::SiStripDetSummary()'
    SiStripDetSummary summaryHV;
                      ^~~~~~~~~
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-08-1100/src/CondCore/SiStripPlugins/plugins/SiStripDetVOff_PayloadInspector.cc:6:0:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-08-1100/src/CondFormats/SiStripObjects/interface/SiStripDetSummary.h:31:12: note: candidate: SiStripDetSummary::SiStripDetSummary(const TrackerTopology*)
   explicit SiStripDetSummary(const TrackerTopology* tTopo) : computeMean_(true), trackerTopo_(tTopo)


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0561d1e
f1103f9
ee01ed6
9617bdf
76961d8
b1ede7a
cd0aacb
f204173
58af6f8
c72da29
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20442/22821/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20442/22821/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@Dr15Jones
Copy link
Contributor Author

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22835/console Started: 2017/09/09 19:53

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20442/22835/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2642440
  • DQMHistoTests: Total failures: 217
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2642034
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit dff5109 into cms-sw:master Sep 10, 2017
@Dr15Jones Dr15Jones deleted the updateTestModules branch September 12, 2017 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants