New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted test modules to global modules #20442
Conversation
ping |
The code-checks are being triggered in jenkins. |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Integration @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
-1 Tested at: 99c202b The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-08-1100/src/TopQuarkAnalysis/Examples/plugins/TopGenEventAnalyzer.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-08-1100/src/TopQuarkAnalysis/Examples/plugins/HypothesisAnalyzer.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-08-1100/src/TopQuarkAnalysis/Examples/plugins/TopTauAnalyzer.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-08-1100/src/TopQuarkAnalysis/Examples/plugins/TopMuonAnalyzer.cc /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-08-1100/src/CondCore/SiStripPlugins/plugins/SiStripDetVOff_PayloadInspector.cc: In member function 'virtual bool {anonymous}::SiStripDetVOffTest::fill(const std::vector, std::allocator > > >&)': /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-08-1100/src/CondCore/SiStripPlugins/plugins/SiStripDetVOff_PayloadInspector.cc:171:22: error: no matching function for call to 'SiStripDetSummary::SiStripDetSummary()' SiStripDetSummary summaryHV; ^~~~~~~~~ In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-08-1100/src/CondCore/SiStripPlugins/plugins/SiStripDetVOff_PayloadInspector.cc:6:0: /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-09-08-1100/src/CondFormats/SiStripObjects/interface/SiStripDetSummary.h:31:12: note: candidate: SiStripDetSummary::SiStripDetSummary(const TrackerTopology*) explicit SiStripDetSummary(const TrackerTopology* tTopo) : computeMean_(true), trackerTopo_(tTopo) The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
Please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
No description provided.