Update SiStripDetSummary usage in the SiStrip Payload Inspector

[pieterdavid]

This should solve the conflict between the changes in #20274 and #20184, and fix the compile errors in new PR tests and the integration builds.
@mmusich could you check that this does not break the SiStrip Payload Inspector?

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

A new Pull Request was created by @pieterdavid (Pieter David) for master.

It involves the following packages:

CondCore/SiStripPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20448/605

[mmusich]

Hi @pieterdavid, thanks for the quick fix. It looks OK to me. I cannot test this until tomorrow. For the time being I suggest this to be merged as is, to avoid compilation issues in other integration tests, and then test it and eventually correct afterward. Unfortunately, I think, the PI applications cannot be tested in cmssw unit tests if (at least reading) database credentials are made available to the bot. @ggovi please comment on the last point.

[davidlange6]

merge On 10 Sep 2017, at 10:23, Marco Musich <notifications@github.com<mailto:notifications@github.com>> wrote: Hi @pieterdavid<https://github.com/pieterdavid>, thanks for the quick fix. It looks OK to me. I cannot test this until tomorrow. For the time being I suggest this to be merged as is, to avoid compilation issues in other integration tests, and then test it and eventually correct afterward. Unfortunately, I think, the PI applications cannot be tested in cmssw unit tests if (at least reading) database credentials are made available to the bot. @ggovi<https://github.com/ggovi> please comment on the last point. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#20448 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzyw4rC9G-aCYn1clwcDaTHYNS0JCwLks5sg5xNgaJpZM4PSFNs>.

[mmusich]

Hello all,
just for the sake of completeness I tested these additions in CMSSW_9_4_X_2017-09-10-2300 which contains this PR, and things look good - as expected:

• SiStripApvGainsByPartition
  

• SiStripApvGainsComparatorByPartition

• SiStripBadStripByRegion

• SiStripDetVOffByRegion

therefore there is no need to further amend these codes.

M.