Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RelVal fix for HI Jet DQM #20454

Merged
merged 3 commits into from Sep 12, 2017
Merged

Conversation

kurtejung
Copy link
Contributor

@kurtejung kurtejung commented Sep 11, 2017

minor fixes for HI Jet DQM relval

Extension of PR #19943

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20454/617

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20454/617/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20454/617/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly (this will soon be required for PRs to be considered)

@smuzaffar
Copy link
Contributor

smuzaffar commented Sep 11, 2017

@kurtejung , can you please apply the code-checks too. As of today, all new PRs needs to have code-checks passed
https://hypernews.cern.ch/HyperNews/CMS/get/swDevelopment/3422/3.html

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20454/624

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kurtejung (Kurt Jung) for master.

It involves the following packages:

DQMOffline/JetMET

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @seemasharmafnal, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test workflow 140.51,140.52

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 11, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22876/console Started: 2017/09/11 22:59

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20454/22876/summary.html

There are some workflows for which there are errors in the baseline:
1330.0 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2563849
  • DQMHistoTests: Total failures: 214
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2563449
  • DQMHistoTests: Total skipped: 186
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@smuzaffar
Copy link
Contributor

@kmaeshima, @vanbesien, @vazzolini, @dmitrijus , can we get dqm signatures for this PR. This fixes two failing workflows (140.51, 140.52)

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 97e1c88 into cms-sw:master Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants