Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edm::refToPtr now handles null Refs #2049

Merged
merged 1 commit into from Jan 16, 2014

Conversation

Dr15Jones
Copy link
Contributor

Previous, edm::refToPtr would cause an exception to happen if it was passed a ‘null’ edm::Ref. This change now just returns a null edm::Ptr in such a case.

Previous, edm::refToPtr would cause an exception to happen if it was passed a ‘null’ edm::Ref. This change now just returns a null edm::Ptr in such a case.
@Dr15Jones
Copy link
Contributor Author

@jpavel @slava77 This will fix a problem seen on #1817

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

edm::refToPtr now handles null Refs

It involves the following packages:

DataFormats/Common

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@Dr15Jones
Copy link
Contributor Author

+1

@slava77
Copy link
Contributor

slava77 commented Jan 16, 2014

On 1/16/14, 9:10 PM, Chris Jones wrote:

@jpavel https://github.com/jpavel @slava77
https://github.com/slava77 This will fix a problem seen on #1817
#1817

Thanks a lot, Chris.

    --slava


Reply to this email directly or view it on GitHub
#2049 (comment).


Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)


@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Jan 16, 2014
…oPtr

Framework fixes -- edm::refToPtr now handles null Refs
@ktf ktf merged commit 946c69c into cms-sw:CMSSW_7_0_X Jan 16, 2014
@Dr15Jones Dr15Jones deleted the dealWithNullRefsInConversionToPtr branch February 6, 2014 20:47
@jpavel jpavel mentioned this pull request Mar 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants