Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix histogram limits in SiPixelClusterSource #20498

Merged
merged 2 commits into from Sep 14, 2017
Merged

Fix histogram limits in SiPixelClusterSource #20498

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99169db
Fix histogram limits in SiPixelClusterSource
Dr15Jones Sep 13, 2017
5326feb
Applied clang-tidy changes
Dr15Jones Sep 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions DQM/SiPixelMonitorCluster/src/SiPixelClusterSource.cc
View file
Open in desktop
Expand Up @@ -40,7 +40,7 @@
#include "DataFormats/TrackerCommon/interface/TrackerTopology.h"
//
#include <string>
#include <stdlib.h>
#include <cstdlib>

using namespace std;
using namespace edm;
Expand Down Expand Up @@ -86,7 +86,7 @@ SiPixelClusterSource::~SiPixelClusterSource()
std::map<uint32_t,SiPixelClusterModule*>::iterator struct_iter;
for (struct_iter = thePixelStructure.begin() ; struct_iter != thePixelStructure.end() ; struct_iter++){
delete struct_iter->second;
struct_iter->second = 0;
struct_iter->second = nullptr;
}
}

Expand Down Expand Up @@ -160,6 +160,7 @@ void SiPixelClusterSource::bookHistograms(DQMStore::IBooker & iBooker, edm::Run
if (i==1) { ybins = 42; ymin = -10.5; ymax = 10.5; }
if (i==2) { ybins = 66; ymin = -16.5; ymax = 16.5; }
if (i==3) { ybins = 90; ymin = -22.5; ymax = 22.5; }
if (i==4) { ybins = 130; ymin = -32.5; ymax = 32.5; }
ss1.str(std::string()); ss1 << "pix_bar Occ_roc_online_" + digisrc_. label() + "_layer_" << i;
ss2.str(std::string()); ss2 << "Pixel Barrel Occupancy, ROC level (Online): Layer " << i;
meZeroRocBPIX.push_back(iBooker.book2D(ss1.str(),ss2.str(),72,-4.5,4.5,ybins,ymin,ymax));
Expand Down Expand Up @@ -296,7 +297,7 @@ void SiPixelClusterSource::buildStructure(const edm::EventSetup& iSetup){

for(TrackerGeometry::DetContainer::const_iterator it = pDD->dets().begin(); it != pDD->dets().end(); it++){

if(dynamic_cast<PixelGeomDetUnit const *>((*it))!=0){
if(dynamic_cast<PixelGeomDetUnit const *>((*it))!=nullptr){

DetId detId = (*it)->geographicalId();
const GeomDetUnit * geoUnit = pDD->idToDetUnit( detId );
Expand Down