Fix to prevent possible crashes if the prescale table changes during job

[apana]

Fix to prevent possible crashes in the L1TGlobalUtil code in CMSSW jobs where the prescale table is updated during the job. In the previous version this could sometimes cause an out-of-range exception.

[cmsbuild]

@apana, CMSSW_9_4_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20503/681

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20503/681/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20503/681/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly (this will soon be required for PRs to be considered)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20503/683

[cmsbuild]

A new Pull Request was created by @apana (Leonard Apanasvich) for master.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22990/console Started: 2017/09/15 08:57

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: 9efa97e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20503/22990/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9f20abe
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20503/22990/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20503/22990/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20503/22990/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2646869
• DQMHistoTests: Total failures: 198
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2646482
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[davidlange6]

+1