Step 1 amendment: Simulation Clang tidy code-checks-all and Clang Warnings Removed

[ianna]

• This PR is based on Step 1: Simulation Clang tidy code-checks-all #20514
• Unused variables removed

@civanch - FYI, just to make sure that modifications by hand do not introduce any changes. When #20514 is merged, I'll rebase this one if needed.

[ianna]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20524/710

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22991/console Started: 2017/09/15 09:06

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

SimG4CMS/Calo
SimG4CMS/CherenkovAnalysis
SimG4CMS/EcalTestBeam
SimG4CMS/FP420
SimG4CMS/Forward
SimG4CMS/HGCalTestBeam
SimG4CMS/HcalTestBeam
SimG4CMS/Muon
SimG4CMS/ShowerLibraryProducer
SimG4CMS/Tracker
SimG4Core/SensitiveDetector
SimRomanPot/SimFP420

@cmsbuild, @civanch, @mdhildreth, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @argiro this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[ianna]

hold

[cmsbuild]

Pull request has been put on hold by @ianna
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[cmsbuild]

+1
Tested at: 3004b34
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20524/22991/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9f20abe
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20524/22991/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20524/22991/git-merge-result

[cmsbuild]

Comparison job queued.

[civanch]

+1
@kpedro88 , it is a small cleanup on top of previous PR

[davidlange6]

merge

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20524/22991/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2646869
• DQMHistoTests: Total failures: 213
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2646467
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files