fixes needed for llvm 5.0: use fully qualified clangcms::support namespace

[smuzaffar]

this is needed for llvm 5.0.0

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_9_4_DEVEL_X.

It involves the following packages:

Utilities/StaticAnalyzers

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test with cms-sw/cmsdist#3412

[cmsbuild]

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3412
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23015/console

[cmsbuild]

-1

Tested at: a7a1eea

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f4a63d4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20541/23015/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20541/23015/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20541/23015/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test testNumba had ERRORS
---> test testhep_ml had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f4a63d4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20541/23015/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20541/23015/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20541/23015/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 18768 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2646869
• DQMHistoTests: Total failures: 91430
• DQMHistoTests: Total nulls: 7
• DQMHistoTests: Total successes: 2555243
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20541/740

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20541/740/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20541/740/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly (this will soon be required for PRs to be considered)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20541/741

[cmsbuild]

Pull request #20541 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again.

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23017/console Started: 2017/09/16 08:55

[cmsbuild]

+1
Tested at: 0daba23
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20541/23017/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
30ee0a6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20541/23017/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20541/23017/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20541/23017/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2648186
• DQMHistoTests: Total failures: 206
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2647791
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[smuzaffar]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)