Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[93x] Stub builder fix and new SW - L1T Track #20592

Merged
merged 2 commits into from Sep 21, 2017

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Sep 19, 2017

93x - This PR contains an important bug fix for the Phase II tracker stub builder

backport of #20492

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2017

A new Pull Request was created by @rekovic for CMSSW_9_3_X.

It involves the following packages:

L1Trigger/TrackTrigger

@cmsbuild, @rekovic, @mulhearn, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko, @sviret this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor Author

rekovic commented Sep 19, 2017

backport of #20492

@rekovic
Copy link
Contributor Author

rekovic commented Sep 19, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23095/console Started: 2017/09/19 21:38

@rekovic
Copy link
Contributor Author

rekovic commented Sep 19, 2017

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20592/23095/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2645486
  • DQMHistoTests: Total failures: 310
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2644987
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f90f7d0 into cms-sw:CMSSW_9_3_X Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants