Add electrons from HGCAL in the pfCandidate collection

[rovere]

The previously saved collection is created before merging the Barrel and HGCAL-related, sim-driven, components together. The newly saved collection will contain all pfcandidates that should be used to perform physics studies.
This will only affect PhaseII workflows. I expect no regression and very tiny effect on the event size of the final ROOT file.

Also, electrons built within the HGCAL volume were not saved into the particleFlow pfCandidate collection, causing strange effects (artificial MET, missing JETs etc...). Now they are forced into the final collection.

@malgeri, @cseez, @felicepantaleo @kpedro88

Backport of #20614

[cmsbuild]

A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_9_3_X.

It involves the following packages:

RecoParticleFlow/Configuration

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray, @seemasharmafnal, @bachtis, @cbernet this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

• Backported from Add electrons from HGCAL in the pfCandidate collection #20614

[kpedro88]

assign upgrade

[kpedro88]

backport of #20614

[kpedro88]

please test

[cmsbuild]

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23148/console Started: 2017/09/21 17:29

[cmsbuild]

+1
Tested at: 3f08bd9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20615/23148/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
971f5b1
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20615/23148/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20615/23148/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20615/23148/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2645486
• DQMHistoTests: Total failures: 195
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2645102
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[cmsbuild]

Pull request #20615 was updated. @perrotta, @cmsbuild, @kpedro88, @slava77 can you please check and sign again.

[cmsbuild]

Pull request #20615 was updated. @perrotta, @cmsbuild, @kpedro88, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23248/console Started: 2017/09/27 14:55

[cmsbuild]

+1
Tested at: a9e1211
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20615/23248/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
eea683a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20615/23248/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20615/23248/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20615/23248/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 695 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2645486
• DQMHistoTests: Total failures: 264
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2645033
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[kpedro88]

+1

[slava77]

+1

for #20615 a9e1211

• backport of Add electrons from HGCAL in the pfCandidate collection #20614 with changes identical to already merged master version Add electrons from HGCAL in the pfCandidate collection #20614 c55b98d; needed for HGCAL TDR release
• jenkins tests pass and comparisons with baseline show about the same differences as was seen in the master PR testing, starting from PF candidate content adding electrons

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

merge