Add possibility to cut on timing to IVF

[lgray]

This PR adds the possibility to cut on the time significance between a vertex with timing and a time stamped track.

Timing is checked for dynamically in both the vertex and the transient track. If not present in both the timing cut is skipped.

This will only affect timing workflows where the 1D vertex reconstruction is overridden (Phase2_timing_layer / D19).

[cmsbuild]

The code-checks are being triggered in jenkins.

[lgray]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20640/936

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for master.

It involves the following packages:

RecoVertex/AdaptiveVertexFinder
TrackingTools/TransientTrack

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@gpetruc, @pvmulder, @HuguesBrun, @bellan, @makortel, @felicepantaleo, @acaudron, @abbiendi, @GiacomoSguazzoni, @mverzett, @rovere, @VinInn, @calderona, @imarches, @JyothsnaKomaragiri, @jhgoh, @ferencek, @battibass, @ebrondol, @trocino, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[lgray]

@cmsbuild please abort

(realized I forgot a few things)

[cmsbuild]

Jenkins tests are aborted.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20640/940

[cmsbuild]

Pull request #20640 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

Pull request #20640 was updated. @perrotta, @cmsbuild, @monttj, @kpedro88, @slava77 can you please check and sign again.

[cmsbuild]

-1

Tested at: 7a501f1

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c738e9e
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20640/24406/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20640/24406/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20640/24406/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafExamples had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c738e9e
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20640/24406/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20640/24406/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20640/24406/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2832699
• DQMHistoTests: Total failures: 99
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2832422
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.94000000009 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[slava77]

+1

for #20640 7a501f1

• implementation is in line with the description; only workflows with track time information [I2 phase-2 detector] are affected
• jenkins tests pass
• some additional performance comparisons notes are in Add possibility to cut on timing to IVF #20640 (comment)

[kpedro88]

+1

[slava77]

@davidlange6

[in absence of analysis signature] this PR is now fully signed. Please check it.
Thank you.

[davidlange6]

yes, its on the list..

…

On Nov 15, 2017, at 4:16 PM, Slava Krutelyov ***@***.***> wrote: @davidlange6 [in absence of analysis signature] this PR is now fully signed. Please check it. Thank you. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[davidlange6]

merge

[slava77]

A notable feature of this PR is that b-tagging is now not reproducible due to unreproducible randomness in the phase-2 workflows with timing.
#20621 is still open.

[kpedro88]

but only in the timing workflow, right?

[slava77]

but only in the timing workflow, right?

yes, only in the timing workflows and only in multi-threaded ones.