Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete unused PFBlockElementTrack [93X] #20670

Merged
merged 2 commits into from
Sep 28, 2017

Conversation

kpedro88
Copy link
Contributor

backport of #20669

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the CMSSW_9_3_X milestone Sep 27, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23255/console Started: 2017/09/27 17:30

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 27, 2017

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_9_3_X.

It involves the following packages:

RecoParticleFlow/PFProducer

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray, @seemasharmafnal, @bachtis, @cbernet this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23257/console Started: 2017/09/27 17:38

@cmsbuild
Copy link
Contributor

Pull request #20670 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Sep 27, 2017

@cmsbuild please test

the last attempt failed with messages including one like

Caused: java.io.IOException: Backing channel 'cmsbuild29' is disconnected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23281/console Started: 2017/09/28 01:28

@slava77
Copy link
Contributor

slava77 commented Sep 27, 2017

+1

for #20670 c5b5147

  • the same fix; the same topic branch and commit ID as the master version
  • jenkins tests pass

looks essential for technical integrity of phase-2 production reco jobs.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20670/23281/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2645486
  • DQMHistoTests: Total failures: 208
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2645089
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 18774e6 into cms-sw:CMSSW_9_3_X Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants