Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Candidate+Point seeded tracking region producer for Tau HLT tracking #20672

Merged
merged 9 commits into from Oct 6, 2017

Conversation

tstreble
Copy link
Contributor

Adds a new tracking region producer for HLT Tracking.
Provides same functionality than existing CandidateSeededTrackingRegion and PointSeededTrackingRegion producers + introduces new functionality with combination of candidate+point-seeded regions.
Once integrated and HLT configuration is updated, possible to make CandidateSeededTrackingRegion and PointSeededTrackingRegion producers deprecated.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20672/1003

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20672/1003/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20672/1003/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20672/1004

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tstreble for master.

It involves the following packages:

RecoTauTag/HLTProducers
RecoTracker/TkTrackingRegions

@perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 28, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23284/console Started: 2017/09/28 06:37

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20672/1158

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2017

Pull request #20672 was updated. @perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please check and sign again.

@perrotta
Copy link
Contributor

perrotta commented Oct 5, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23460/console Started: 2017/10/05 14:13

@makortel
Copy link
Contributor

makortel commented Oct 5, 2017 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20672/23460/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2761427
  • DQMHistoTests: Total failures: 246
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2760994
  • DQMHistoTests: Total skipped: 187
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Oct 5, 2017

+1

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 01dc855 into cms-sw:master Oct 6, 2017
cmsbuild added a commit that referenced this pull request Oct 9, 2017
…_92X_2

[backport of #20672] New Candidate+Point seeded tracking region producer for Tau HLT tracking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants