HeavyFlavor Validation update [92X] #20674
Conversation
Internally used filter level assignment relied on the name of the modules, which can be ambiguous. Added an additional check on the type of the module to be a bit more stable and to prevent from multiple modules on the same level. The newly introduced function yields the same levels as the previous definition in dqmBeginRun, without having multiple modules on the same level. Removed some trailing whitespace as well.
clang complained about arrays of chars not being initialized by a constant expression. (gcc compiles without warning on this) Subsequently the call to 'isAnyOf' does not succeed due to: no known conversion from 'const initializer_list<const char *>' to 'const initializer_list<const const char *>' for 2nd argument Removing the second const from const char* const would allow clang to compile but breaks the gcc build due to the same reasoning (but with reversed arguments in this case). Since this is called only in setup I have simply replaced all constexpr char[] by std::string.
- Avoid usage of stringstream where concatenating strings is possible. - Make filter level assignment stable enough to allow for early returns.
|
A new Pull Request was created by @tmadlener (Thomas Madlener) for CMSSW_9_2_X. It involves the following packages: HLTriggerOffline/HeavyFlavor @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
@cmsbuild, please test
… On 27 Sep 2017, at 18:27, cmsbuild ***@***.***> wrote:
A new Pull Request was created by @tmadlener (Thomas Madlener) for CMSSW_9_2_X.
It involves the following packages:
HLTriggerOffline/HeavyFlavor
@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@mtosi this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.
cms-bot commands are listed here
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
backport of #20520
Necessary updates to have meaningful/filled validation plots again for the HeavyFlavor validation package (used by BPH for RelVal):