Backport of Phase I Heavy-ion reco to 92X #20681
Conversation
|
A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for CMSSW_9_2_X. It involves the following packages: Configuration/Generator @perrotta, @GurpreetSinghChahal, @efeyazgan, @vazzolini, @dmitrijus, @kmaeshima, @perrozzi, @civanch, @kpedro88, @fabozzi, @cmsbuild, @kkousour, @franzoni, @thuer, @slava77, @mdhildreth, @vanbesien, @govoni, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
| steps['PhotonJets_Pt_10_13_HI']=merge([hiDefaults,steps['PhotonJets_Pt_10_13']]) | ||
| steps['ZMM_13_HI']=merge([hiDefaults,steps['ZMM_13']]) | ||
| steps['ZEEMM_13_HI']=merge([hiDefaults,steps['ZEEMM_13']]) | ||
| steps['HydjetQ_MinBias_5020GeVINPUT']={'INPUT':InputInfo(dataSet='/RelValHydjetQ_MinBias_5020GeV/%s/GEN-SIM'%(baseDataSetRelease[9],),location='STD',split=5)} |
There was a problem hiding this comment.
@mandrenguyen
Since the workflows HydjetQ_MinBias_5020GeV, HydjetQ_MinBias_2760GeV
are not defined anymore in relval_standard, you can remove the input gensim
as well. I am referring to:
https://github.com/mandrenguyen/cmssw/blob/8c5d1b05aea67ee2468ee495b587a343434e96d9/Configuration/PyReleaseValidation/python/relval_steps.py#L688-L689
There was a problem hiding this comment.
Finished visual inspection of the backport PR: it precisely mirrors the several PRs which are backported here. Only a couple of comments left about possible better indentations: take them into account if and when you also deal with the other comment received so far (https://github.com/cms-sw/cmssw/pull/20681/files#r141644140)
| '--mc':'', | ||
| '--era' : 'Run2_2017', | ||
| '--filetype':'DQM', | ||
| '--scenario':'HeavyIons'}]) |
There was a problem hiding this comment.
Please indent same as above
| '--mc':'', | ||
| '--era' : 'Run2_2016,Run2_HI', | ||
| '--filetype':'DQM', | ||
| '--scenario':'HeavyIons'}]) | ||
| '--scenario':'HeavyIons'}]) |
There was a problem hiding this comment.
Please indent same as above
|
Comparing the DQM plots produced by jenkins in wf 140.53, re-reco of RunHI2011, one can notice differences of several jet related quantities and derived higher level objects, eg akPu3PFJets As well as the appearance of the reduced ecal recHits: I don't know which one of the backported original PR is at the origin of this modifications in the HI2011 re-reco (jenkins outputs aleady disappeared frome those PRs). I also don't think this can be a problem, as no re-processing of 2011 data was done yet with 92X, as far as I know. Just please check and confirm that what you see is actually what you expect. |
Removed unused GS inputs and fixed indentation
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #20681 was updated. @perrotta, @GurpreetSinghChahal, @efeyazgan, @vazzolini, @dmitrijus, @kmaeshima, @perrozzi, @civanch, @kpedro88, @fabozzi, @cmsbuild, @kkousour, @franzoni, @thuer, @slava77, @mdhildreth, @vanbesien, @govoni, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
|
+1 |
|
merge |
A fill of Xenon-Xenon collisions is planned as early as October 12th.
This may require running the heavy-ion reconstruction sequence.
The HI reco was only fully updated to use the Phase I detector in 93X.
However, the plan is to stick with 92X for prompt reco of this data.
The PR backports all the dev's that went into 93X to 92X.
Each PR corresponds to a separate commit.