Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[93x backport] Enable usage of TTreeCache in Fireworks #20721

Merged
merged 2 commits into from
Oct 12, 2017

Conversation

osschar
Copy link
Contributor

@osschar osschar commented Oct 2, 2017

This is backport of #20702

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2017

A new Pull Request was created by @osschar (Matevž Tadel) for CMSSW_9_3_X.

It involves the following packages:

DataFormats/FWLite
Fireworks/Core

@cmsbuild, @smuzaffar, @Dr15Jones, @alja can you please review it and eventually sign? Thanks.
@alja, @rovere, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@alja
Copy link
Contributor

alja commented Oct 2, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23374/console Started: 2017/10/02 20:06

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20721/23374/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2708283
  • DQMHistoTests: Total failures: 230
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2707866
  • DQMHistoTests: Total skipped: 187
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 9 edm output root files, 26 DQM output files

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 84ba24b into cms-sw:CMSSW_9_3_X Oct 12, 2017
@osschar osschar deleted the 932-fworks-xrd branch September 7, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants