Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce semi-deterministic smearing for e/gamma objects #20878

Merged
merged 1 commit into from Oct 12, 2017

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Oct 10, 2017

Extend EGMSmearer to allow a semi-deterministic smearing dependent only on the event.

Needed for reproducibility of NanoAOD on MC when running multithreaded.

Uses std::seed_seq hash together a bunch of info about the event; tested on 50k events that the random numbers look random.

@arizzi @emanueledimarco @peruzzim

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20878/1347

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for master.

It involves the following packages:

EgammaAnalysis/ElectronTools

@cmsbuild, @monttj can you please review it and eventually sign? Thanks.
@jainshilpi, @Sam-Harper, @varuns23 this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@gpetruc
Copy link
Contributor Author

gpetruc commented Oct 10, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23650/console Started: 2017/10/10 18:29

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20878/23650/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2766087
  • DQMHistoTests: Total failures: 108
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2765808
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit b652b5c into cms-sw:master Oct 12, 2017
gpetruc added a commit to gpetruc/cmssw that referenced this pull request Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants